feat(@schematics/angular): add skipInstall option to library schematic

alan-agius4 · filipesilva · commit c35b44ca4d8d · 2018-08-04T12:46:55.000+01:00
Closes: angular#11343
diff --git a/docs/documentation/generate/library.md b/docs/documentation/generate/library.md
@@ -51,6 +51,15 @@ Generate a library project for Angular.
     Do not add dependencies to package.json.
   </p>
 </details>
+<details>
+  <summary>skip-install</summary>
+  <p>
+    <code>--skip-install</code>
+  </p>
+  <p>
+    Do not add dependencies to package.json.
+  </p>
+</details>
 <details>
   <summary>skip-ts-config</summary>
   <p>
diff --git a/packages/schematics/angular/library/index.ts b/packages/schematics/angular/library/index.ts
@@ -245,7 +245,7 @@ export default function (options: LibraryOptions): Rule {
         project: options.name,
       }),
       (_tree: Tree, context: SchematicContext) => {
-        if (!options.skipPackageJson) {
+        if (!options.skipPackageJson && !options.skipInstall) {
           context.addTask(new NodePackageInstallTask());
         }
       },
diff --git a/packages/schematics/angular/library/index_spec.ts b/packages/schematics/angular/library/index_spec.ts
@@ -29,6 +29,7 @@ describe('Library Schematic', () => {
     entryFile: 'my_index',
     skipPackageJson: false,
     skipTsConfig: false,
+    skipInstall: false,
   };
   const workspaceOptions: WorkspaceOptions = {
     name: 'workspace',
diff --git a/packages/schematics/angular/library/schema.d.ts b/packages/schematics/angular/library/schema.d.ts
@@ -14,17 +14,21 @@ export interface Schema {
   /**
    * The path to create the interface.
    */
-  entryFile: string;
+  entryFile?: string;
   /**
    * The prefix to apply to generated selectors.
    */
   prefix?: string;
   /**
    * Do not add dependencies to package.json (e.g., --skipPackageJson)
    */
-  skipPackageJson: boolean;
+  skipPackageJson?: boolean;
+  /**
+   * Skip installing dependency packages.
+   */
+  skipInstall?: boolean;
   /**
    * Do not update tsconfig.json for development experience (e.g., --skipTsConfig)
    */
-  skipTsConfig: boolean;
+  skipTsConfig?: boolean;
 }
diff --git a/packages/schematics/angular/library/schema.json b/packages/schematics/angular/library/schema.json
@@ -30,6 +30,11 @@
       "default": false,
       "description": "Do not add dependencies to package.json."
     },
+    "skipInstall": {
+      "description": "Skip installing dependency packages.",
+      "type": "boolean",
+      "default": false
+    },
     "skipTsConfig": {
       "type": "boolean",
       "default": false,

Original file line number	Diff line number	Diff line change
`@@ -245,7 +245,7 @@ export default function (options: LibraryOptions): Rule {`
`245`	`245`	`project: options.name,`
`246`	`246`	`}),`
`247`	`247`	`(_tree: Tree, context: SchematicContext) => {`
`248`		`- if (!options.skipPackageJson) {`
	`248`	`+ if (!options.skipPackageJson && !options.skipInstall) {`
`249`	`249`	`context.addTask(new NodePackageInstallTask());`
`250`	`250`	`}`
`251`	`251`	`},`