Skip to content

Conversation

@rupel190
Copy link
Contributor

@rupel190 rupel190 commented Aug 2, 2024

There is no straightforward way of resuming/unpausing a paused recorder as play() and pause() result in an error and the underlying MediaRecorder is exposed neither.

Resumes recorder by calling start() as per expecation in issue #1026.

Tests are successful.

@rupel190 rupel190 closed this Aug 2, 2024
@rupel190 rupel190 deleted the feat/recorder-resume branch August 2, 2024 01:29
@rupel190 rupel190 restored the feat/recorder-resume branch August 3, 2024 00:22
@rupel190 rupel190 reopened this Aug 3, 2024
@tambien tambien merged commit ead4f21 into Tonejs:dev Feb 18, 2025
@tambien
Copy link
Contributor

tambien commented Feb 18, 2025

Thank you!

Fixes #1026

tambien added a commit that referenced this pull request Apr 27, 2025
* Removing double-encoding of urls (#1254)

* Removing double-encoding of urls, testing baseUrl

* testing file with space

* updating version

* Removing forum link from README (#1247)

* Bump braces from 3.0.2 to 3.0.3 (#1255)

Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3.
- [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md)
- [Commits](micromatch/braces@3.0.2...3.0.3)

---
updated-dependencies:
- dependency-name: braces
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* typo (#1270)

it's -> its

* Updating docs for FeedbackEffect

Closes #1302

* Using latest web-test-runner

* using latest puppeteer explicitly

* Working on getting puppeteer to pass (#1312)

* Reverb input string time (#1313)

* Working on getting puppeteer to pass

* Handles string inputs to Reverb

Fixes #1253

* Adding simple scratch route with autoreload (#1314)

* Working on getting puppeteer to pass

* Handles string inputs to Reverb

* adding scratch path

* Timeline cancelled within setTimeout callback (#1315)

* Working on getting puppeteer to pass

* Handles string inputs to Reverb

* adding scratch path

* Using forEachBefore instead of peek/shift while loop

* removing events after they are invoked

* Stale actions (#1316)

* fixing doc link

* Closing stale feature requests

* add codcov (#1318)

* Updated CHANGELOG.md, fix typo(s) (#1287)

* Export remaining effect option interfaces (#1293)

* fix markdown brackets in description (#1269)

* Bump @75lb/deep-merge from 1.1.1 to 1.1.2 (#1267)

Bumps [@75lb/deep-merge](https://github.com/75lb/deep-merge) from 1.1.1 to 1.1.2.
- [Commits](75lb/deep-merge@v1.1.1...v1.1.2)

---
updated-dependencies:
- dependency-name: "@75lb/deep-merge"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Recorder resumes if start() is called in paused state (#1266)

* chore: updating Changelog

* chore: small nit change to changelog

* Add custom context support to Filter.getFrequencyResponse (#1328)

* Bump @babel/runtime from 7.24.4 to 7.26.10 (#1325)

Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.24.4 to 7.26.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime)

---
updated-dependencies:
- dependency-name: "@babel/runtime"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump serialize-javascript and mocha (#1321)

Bumps [serialize-javascript](https://github.com/yahoo/serialize-javascript) to 6.0.2 and updates ancestor dependency [mocha](https://github.com/mochajs/mocha). These dependencies need to be updated together.


Updates `serialize-javascript` from 6.0.0 to 6.0.2
- [Release notes](https://github.com/yahoo/serialize-javascript/releases)
- [Commits](yahoo/serialize-javascript@v6.0.0...v6.0.2)

Updates `mocha` from 9.2.2 to 11.1.0
- [Release notes](https://github.com/mochajs/mocha/releases)
- [Changelog](https://github.com/mochajs/mocha/blob/main/CHANGELOG.md)
- [Commits](mochajs/mocha@v9.2.2...v11.1.0)

---
updated-dependencies:
- dependency-name: serialize-javascript
  dependency-type: indirect
- dependency-name: mocha
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: FEZfan <[email protected]>
Co-authored-by: Nicholas Wilson <[email protected]>
Co-authored-by: Yann Mazita <[email protected]>
Co-authored-by: Charles Matthews <[email protected]>
Co-authored-by: rupel190 <[email protected]>
Co-authored-by: 础砜 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants