Skip to content

Conversation

@andyfinnell
Copy link
Collaborator

Summary

We want to make Texture build with recent tools like Xcode 15. Part of this is bumping the minimum supported OS to iOS 14.

I only removed the dead code (i.e. code gated on versions older than iOS 14). There are still some warnings about outdated APIs in use, but they are non-trivial changes to fix. Also, several of the examples rely on remote media (images or videos) that no longer exist. If they were trivially fixable, I fixed them. If not, I left them.

Test plan

Run all the examples and verify it works as I expect. Run all the unit tests and make them pass.

## Summary

We want to make Texture build with recent tools like Xcode 15. Part of this is bumping the minimum supported OS to iOS 14.

I only removed the dead code (i.e. code gated on versions older than iOS 14). There are still some warnings about outdated APIs in use, but they are non-trivial changes to fix.

## Test plan

Run all the examples. Run all the unit tests and make them pass.
@CLAassistant
Copy link

CLAassistant commented May 17, 2024

CLA assistant check
All committers have signed the CLA.

@andyfinnell andyfinnell merged commit e9bd484 into TextureGroup:master May 21, 2024
@andyfinnell andyfinnell deleted the update-to-xcode-15 branch May 21, 2024 17:04
@mattxw
Copy link

mattxw commented May 24, 2024

Out of curiosity, why do Texture need to bump the minimum iOS version to 14?

muukii pushed a commit to FluidGroup/Texture that referenced this pull request Dec 13, 2024
* Update to Xcode 15

We want to make Texture build with recent tools like Xcode 15. Part of this is bumping the minimum supported OS to iOS 14.

I only removed the dead code (i.e. code gated on versions older than iOS 14). There are still some warnings about outdated APIs in use, but they are non-trivial changes to fix.

Run all the examples. Run all the unit tests and make them pass.

* Use Xcode 15.3 so we have 17.4 simulators

* Fixing an asset catalog compiler error when building against iPhone SE

* Fix a couple of file extensions for assets

A couple of PNGs were marked as JPGs
@brettwillis
Copy link

With this change from iOS 9 -> iOS 14, about 4% of active iOS users were cut off in one fell swoop. Is there a reason that it needed to bump it all the way to iOS 14 in terms of API usage?

Bumping to only iOS 11 or 12, for example, would be significantly better than iOS 14 (eliminates ~2% of active users). But even then if there was no API usage that required this bump then why eliminate those users?

Source: https://iosref.com/ios.

Xcode can still compile for targets lower than iOS 14 with the -Wl,-ld_classic compiler flag (see https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Known-Issues). Can we have some consideration on reverting this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants