Fix element lookup for supplementary attributes. #1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I have accepted the terms for the license. Not sure why the PR hasn't approved that last step. Let me know if there is a step that I missed. |
Contributor
|
@craighowarth Thanks for this PR and sorry that it took a couple of days. LGTM but I would also like to have eyes from @Adlai-Holler and @nguyenhuy on this. |
ernestmama
approved these changes
Nov 4, 2019
nguyenhuy
approved these changes
Dec 24, 2019
Member
nguyenhuy
left a comment
nguyenhuy
left a comment
There was a problem hiding this comment.
LGTM too. Thanks for the fix!
Member
|
Seeing this 6 months later, but wanted to thank you @craighowarth for your analysis of the code and the resulting contribution. It's sincerely appreciated! Supplementary items were not widely utilized by the teams that depended on Texture the most as this code was built out, but it's really valuable for the community to isolate any of the faults in those codepaths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_measureElementsInRect()function inASCollectionLayout.mmwas performing a[elementForItemAtIndexPath:]on the index path for every attribute. Some of those attributes might be supplementary views, but this distinction was being ignored. The fix will check therepresentedElementKindto see if the item is a supplementary view and if it is,[supplementaryElementOfKind:atIndexPath:]will be called instead.