Skip to content

deprecate ASGraphicsCreateImageWithOptions #1704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vovasty merged 1 commit into from
Oct 16, 2019
Merged

deprecate ASGraphicsCreateImageWithOptions #1704

vovasty merged 1 commit into from
Oct 16, 2019

Conversation

@vovasty
Copy link
Contributor

@vovasty vovasty commented Oct 9, 2019 •
edited
Loading

ASGraphicsCreateImageWithTraitCollectionAndOptions supersedes ASGraphicsCreateImageWithOptions, thus we deprecate it.
Reference #1675

UIImage (ASDKResizableRoundedRects) is untouched cause requires deprecation of other things
Documentation wasn't created
ASImageNode Extras remains untouched: needs further deprecation(?)

PS
this is the same as #1676

@vovasty vovasty mentioned this pull request Oct 9, 2019
Closed
@vovasty vovasty requested a review from bolsinga October 9, 2019 19:46
@vovasty vovasty merged commit 18fa714 into TextureGroup:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bolsinga bolsinga bolsinga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vovasty @bolsinga