Skip to content

Update FBSnapshotTestCase to iOSSnapshotTestCase (=6.1) #1625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rahul-malik wants to merge 1 commit into from
Closed

Update FBSnapshotTestCase to iOSSnapshotTestCase (=6.1) #1625

rahul-malik wants to merge 1 commit into from

Conversation

@rahul-malik
Copy link
Contributor

@rahul-malik rahul-malik commented Aug 19, 2019

Our snapshot dependency was really out-of-date. This updates us to the latest version which has support for XCTAttachments so you can view reference/failed/diff images from within Xcode!

bolsinga
bolsinga approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@bolsinga bolsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

nguyenhuy
nguyenhuy approved these changes Aug 19, 2019
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Snapshot tests failed though, can you take a look?

@rahul-malik
Copy link
Contributor Author

rahul-malik commented Aug 19, 2019

@nguyenhuy - I noticed we have two reference directories (References_64, References_10 or something like that). Any reason we have both or should we re-record everything?

@bolsinga bolsinga mentioned this pull request May 28, 2020
Merged
@bolsinga
Copy link
Contributor

bolsinga commented May 28, 2020

@nguyenhuy - I noticed we have two reference directories (References_64, References_10 or something like that). Any reason we have both or should we re-record everything?

facebookarchive/AsyncDisplayKit#2295 is something that changes the output file if running against iOS 10.0 and this diff makes all tests run under iOS 10.0.

@bolsinga
Copy link
Contributor

bolsinga commented May 28, 2020

@nguyenhuy - I noticed we have two reference directories (References_64, References_10 or something like that). Any reason we have both or should we re-record everything?

facebookarchive/AsyncDisplayKit#2295 is something that changes the output file if running against iOS 10.0 and this diff makes all tests run under iOS 10.0.

Also the new snapshot lib will replace - in reference image filenames with _.

@bolsinga
Copy link
Contributor

bolsinga commented May 28, 2020

This work was done in #1855.

@bolsinga bolsinga closed this May 28, 2020
@Adlai-Holler Adlai-Holler deleted the rmalik/snapshot-pod-update branch June 5, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nguyenhuy nguyenhuy nguyenhuy approved these changes

@Adlai-Holler Adlai-Holler Awaiting requested review from Adlai-Holler

+1 more reviewer

@bolsinga bolsinga bolsinga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rahul-malik @bolsinga @nguyenhuy