Skip to content

Upgrade textual and python#63

Open
bluefing wants to merge 2 commits intoTextualize:mainfrom
bluefing:main
Open

Upgrade textual and python#63
bluefing wants to merge 2 commits intoTextualize:mainfrom
bluefing:main

Conversation

@bluefing
Copy link

@bluefing bluefing commented Oct 26, 2024

  • Upgrading textual to 0.82.0 required minor Python version bump
  • Minimal change required due to namespace_bindings rename to active_bindings in Textual 0.61.0
  • Limited post upgrade testing.
    • Performed manual smoke test by piping tree into tl and reading a python log file

@bluefing
Upgrade textual and python
f55e5ae 
- Upgrading textual to 0.82.0 required minor Python version bump
- Minimal change required due to namespace_bindings rename to active_bindings in Textual 0.61.0
- Limited post upgrade testing.
    - Performed manual smoke test by piping tree into tl and reading a python log file
@bluefing bluefing closed this Oct 27, 2024
@bluefing
Copy link
Author

bluefing commented Oct 27, 2024

More testing required - tailing is not working

@bluefing
Copy link
Author

bluefing commented Oct 27, 2024

Reopening the PR as tail is working when tl is executed stand alone.
Tail was not working when I had embedded it in another app.

@bluefing bluefing reopened this Oct 27, 2024
@bluefing bluefing mentioned this pull request Oct 27, 2024
Open
@bluefing bluefing marked this pull request as draft October 27, 2024 12:19
@bluefing
Copy link
Author

bluefing commented Oct 27, 2024 •
edited
Loading

Discovered this issue while testing the PR with toolong embedded in another app.
I'll have a look at it to make sure it does not impact stand alone usage.

I suspect it will as

App.check_bindings is now private
https://github.com/Textualize/textual/blob/main/CHANGELOG.md#0690---2024-06-16

image

@bluefing
Fixed "App.check_bindings is now private"
28ecb2c 
Replaced the call with a call to simulate_key
@bluefing
Copy link
Author

bluefing commented Oct 27, 2024 •
edited
Loading

tested that the following are working using Python 3.12.7

  • passing multiple log files
    • tabbed
      tl ../logs/app.log ../logs/app.log.2
    • merged
      tl --merge ../logs/app.log ../logs/app.log.2
  • Find
    • Regex and case sensitive search
    • previous and next
  • Go to
  • Line nos
  • Help
  • Mouse (scroll and shift-scroll) and keyboard navigation (g, shift-g, page-up/down, arrow keys)
  • Overlay

@bluefing bluefing marked this pull request as ready for review October 27, 2024 13:35
@armijnhemel armijnhemel mentioned this pull request Dec 3, 2024
Open
@bluefing bluefing mentioned this pull request Jan 4, 2025
Open
@polygon polygon mentioned this pull request Mar 8, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bluefing