traceback - fixed type hinting for locals_max_length & locals_max_string to support None#3822
Open
talsaiag wants to merge 1 commit intoTextualize:masterfrom
Open
traceback - fixed type hinting for locals_max_length & locals_max_string to support None#3822talsaiag wants to merge 1 commit intoTextualize:masterfrom
talsaiag wants to merge 1 commit intoTextualize:masterfrom
Conversation
Fixed type hinting for locals_max_length & locals_max_string to support None values (per the documentation)
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes type hinting inconsistencies for the locals_max_length and locals_max_string parameters in the traceback module. The parameters were documented to accept None values but were typed as int, causing type checker errors when None was passed.
- Updated type annotations from
inttoOptional[int]for both parameters across multiple functions - Resolves mypy/type checker errors when passing
Noneto these parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed type hinting for locals_max_length & locals_max_string to support None values (per the documentation)
Type of changes
Checklist
Description
Fixes this: