Allow file:// hyperlinks Fixes #3786#3788
Open
mudiko wants to merge 3 commits intoTextualize:masterfrom
Open
Conversation
Author
|
This issue needs a solution, since modern LLM tools such as coding agents need to reference local files. This behavior does not allow rich to be a viable python library for such applications |
|
Thank you for tackling this! I think it's a bit dumb that that is how it has to be done, but upstream |
Author
|
Yes, it could also be replaced by a single liner lambda function, but yea sadly the functions needs to get overwritten. It is also possible to do it by post processing, but I find that even messier. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable file:// hyperlinks in Rich Fixes #3786
Type of changes
Checklist
Description
This PR fixes an issue where
file://hyperlinks were not working in Rich due to the underlying markdown-it-py implementation. The markdown-it-py library blocks file:// URLs for security reasons when rendering in browser environments, but this security restriction doesn't apply to Rich since it runs locally.Problem
file://hyperlinks in Rich markup were not being rendered as clickable linksSolution
file://URLs when rendering hyperlinksfile://URL syntaxExample Usage