Skip to content

Fix UnicodeDecodeError on non-UTF-8 files#151

Merged
rchl merged 6 commits intoSublimeText:masterfrom
q3xq3r:fix/unicode-decode-error
Jun 28, 2021
Merged

Fix UnicodeDecodeError on non-UTF-8 files#151
rchl merged 6 commits intoSublimeText:masterfrom
q3xq3r:fix/unicode-decode-error

Conversation

@q3xq3r
Copy link
Contributor

@q3xq3r q3xq3r commented Jun 28, 2021 •
edited
Loading

Fixes #64

@q3xq3r q3xq3r changed the title Fix UnicodeDecodeError on non-UTF-8 files #64 Fix UnicodeDecodeError on non-UTF-8 files Jun 28, 2021
@rchl
Copy link
Member

rchl commented Jun 28, 2021

Thanks for the fix.
I've made it a bit more generic as I didn't like the simplistic parsing too much.

Also removed some old exception handler that, to my knowledge, could never throw.

@rchl
Copy link
Member

rchl commented Jun 28, 2021

I'll merge as soon as you are happy with my changes.

q3xq3r
q3xq3r commented Jun 28, 2021
View reviewed changes
@q3xq3r q3xq3r requested a review from rchl June 28, 2021 19:52
@q3xq3r
Copy link
Contributor Author

q3xq3r commented Jun 28, 2021

Seems good now.

@rchl rchl merged commit 7397387 into SublimeText:master Jun 28, 2021
@rchl
Copy link
Member

rchl commented Jun 28, 2021

Thanks!

@q3xq3r
Copy link
Contributor Author

q3xq3r commented Jun 28, 2021

Thanks

@q3xq3r q3xq3r deleted the fix/unicode-decode-error branch June 28, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchl rchl Awaiting requested review from rchl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ST3: UnicodeDecodeError on non-UTF-8 files

2 participants

@q3xq3r @rchl