Enhance touchscreen handling, fake deck configuration, and UI styling#512
Draft
designgears wants to merge 26 commits into
Draft
Enhance touchscreen handling, fake deck configuration, and UI styling#512designgears wants to merge 26 commits into
designgears wants to merge 26 commits into
Conversation
Fixed focus logic in ScreenBar to properly detect swipe gestures Corrected inverted swipe direction (left/right events were swapped) Added swipe event support for dial inputs (matching existing touch press behavior)
clean up whitespace
…und image handling
…es in DeckController and BackgroundVideoCache
… there were ampersands.
- Added checks for touchscreen size to prevent errors when it is not available. - Updated DeckController and related classes to return None for touchscreen size when not applicable. - Improved fake deck loading logic to allow for customizable deck types based on settings. - Enhanced UI components to adapt to real touchscreen sizes, ensuring accurate display and interaction. - Refactored settings page to dynamically update deck type selections based on the number of fake decks configured.
This reverts commit 75a485a.
Member
|
First of all, thank you!
I really like that it's not possible to configure the type of fake decks! Great work! |
Contributor
Author
This was all rushed together just as a proof of concept, I'll keep hammering on the fake deck type swap and see if I can make that play nice. Edit: reworked what I was trying to do before, figured out my mistake and made that work pretty well! |
…k types - Added reload_fake_deck method to DeckManager for targeted fake deck updates without reloading all decks. - Method removes and re-adds specific fake deck at correct position to apply type changes. - Updated settings page to use reload_fake_deck instead of load_fake_decks for better performance when changing deck types. - Ensures proper ordering of hardware and fake decks in controller lists and UI.
… accurrate." This reverts commit 29a4ebd.
…xt where there were ampersands." This reverts commit 5a921a7.
…references components - Added background color styling to preferenceswindow, preferencespage, and preferencesgroup elements to prevent text rendering artifacts in the settings interface.
- Import html module for entity escaping - Escape HTML/XML entities in translated strings before returning them to prevent markup parsing issues in GTK labels and UI elements
…d as CSV column separators, causing the column alignment to shift.
bc6235e to
c48a30e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves touchscreen handling, enhances fake deck configuration capabilities, fixes UI styling to accurately match physical hardware, and resolves a GObject Introspection warning.
Changes
1. Enhance touchscreen handling and fake deck configuration
Nonefor touchscreen size when not applicableFiles changed:
src/backend/DeckManagement/DeckController.pysrc/backend/DeckManagement/DeckManager.pysrc/backend/DeckManagement/Subclasses/FakeDeck.pysrc/windows/Settings/Settings.pysrc/windows/mainWindow/DeckPlus/ScreenBar.pysrc/windows/mainWindow/elements/KeyGrid.py2. Fix GObject Introspection warning
gi.require_version("Gdk", "4.0")toHelperMethods.pyto resolve GObject Introspection version warningFiles changed:
src/backend/DeckManagement/HelperMethods.pyTesting
Impact
Images
Before:

After:

Fake Decks:



