Added Material Design Icons as assets#377
Conversation
|
I changed the asset to a paginated view and removed the requirement to enter 3 letters. I'm much happier now as you can now browse all icons and it feels more responsive. If we could now figure out how to pack multiple items in every row .... |
|
Could you maybe add some images to how it looks atm? I also am not the biggest fan of using abbreviations in variable names etc, but that could just me as im used to not use abbreviations that are not commonly known. |
There was a problem hiding this comment.
Those should be changed as the app doesnt launch otherwise
There could also be some smaller UI changes aswell like these buttons not being two distinct buttons:

You could make them look more like this:

Otherwise as you already said you should look how to get rows and columns working.
Maybe a Gtk Grid or taking a deeper look at how IconPacks and WallpaperPacks achieve that behavior
Yeah, I had a look but could not find any code influencing the size of the preview. Maybe it's because of how sizes work with actual images and with images created from SVG.... |
Doesnt stuff get converted to an image either way? So svgs or pngs are in the end the same? |
|
Looks so much better! |
|
You could maybe make the images smaller and increase the items per page to 50? |
I couldn't get it to more then 3 entries per row. I think there is still some setting I haven't found.
Not sure about that. Every item adds 0.01 second of loading time, so going from 20 to 50 items increases the loading time from 0.2 to 0.5 seconds. I'll play around with it and see how it feels. |
Could you maybe load the Icons threaded? Basically split the loading into two thread groups both loading 25 items |
I probably could but I don't want to get into that now. I increased the items to 50 per page and the loading time is tolerable. On my machine at least; useres with a weaker rig might be more annoyed. But the current state is damn near perfect for me. |
|
@gensyn I really like the feature, but tbh I don't like that it's a tab in the AssetManager. Instead I would prefer something more generic that works for most svg icons. Then we could move it to the sidebar of the app and only show it if we detect that the current icon is a compatible svg. |
You mean only offer to change color and opacity? I would still like to be able to pick any Material Design Icon from a list without having to obtain it somewhere else first. |
We already have an icon pack feature in the app that we could use for that. |
|
I get what you are saying and it's your call. But I see some benefits in the current implementation:
What do you think of that: we could remove the new tab in the AssetManager and instead show the Material Design Icons as a built-in default icon pack. Whether we offer the option to change color and opacity in the sidebar for all SVGs or within the icon pack is up to you. |
|
I think the Icon Pack is a nice Idea. This could be made even faster by compressing the json file, meaning something like gzip for simple compression or actually looking at Binary formats like |
Sure, you could load any |
I like the idea. |
|
I'll look into it next week and probably set up a new branch and create a new PR. |
|
I finally started working on this and ran into a problem. In When the opacity is changed in the UI I update the SVG string This implicitly does an update but my changes are not applied. If I restart StreamController the new opacity is visible, so the |
Sorry for the late response. No, |







This is something I have been sorely missing: the option to use any Material Design Icon in any color and any opacity as the icon for a key.
I added a new Tab to the
AssetManagerwhere you can search for an icon and set a color and opacity. It's not working 100% as I would like, but it's functional and I'd like to see it included in a future release.Icons are only shown after entering at least 3 letters into the searchbar, otherwise building the icons would take too long.
Points that bug me:
self.set_loading(True)but there seems to be a problem with the threads because the overlay is never shown.@Core447: You are more then welcome to have a look into these cosmetics.
There's also another reason I would like to see this included: If these changes make it into StreamController, I could remove the MDI related code from my plugin and use the native implementation.