Fixed StreamDeck not reconnecting#187
Merged
Merged
Conversation
Member
I think this approach makes more sense because we don't know which other strings are used. However, using the "actual" vendor id should be sufficient, isn't it? |
Contributor
Author
|
I would think so, yes. The vendor ID should be supplied by the StreamDeck itself and therefore always be the same. |
Member
|
Ok, do you want to implement this, or should I do it? |
Contributor
Author
|
I can gladly change my PR on monday, if you dont't want it asap. :) |
Member
|
No need to hurry |
Contributor
Author
|
Ok, I changed the PR to use the vendor ID |
Member
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At least on my system (Ubuntu 24.04), my Stream Deck Mini identifies with vendor name "Elgato_Systems", not "Elgato". So the
on_connect()andon_disconnect()functions were never executed for me. I added "Elgato_Systems" as a valid vendor and now unplugging and reconnecting the StreamDeck works as expected.Alternatively, you could just check for the string "Elgato" in the vendor name or check the actual vendor id, which should be identical on all systems.