Skip to content

Correct and clean up m4.2#23

Merged
goedman merged 1 commit intoStatisticalRethinkingJulia:masterfrom
karajan9:patch-2
May 9, 2020
Merged

Correct and clean up m4.2#23
goedman merged 1 commit intoStatisticalRethinkingJulia:masterfrom
karajan9:patch-2

Conversation

@karajan9
Copy link
Contributor

@karajan9 karajan9 commented May 9, 2020

Most importantly switch x and y in the model definition so the model works correctly.
Removed some superfluous converting and simplified DataFrames syntax (I find df2.weight easier to read than df2[:, :weight] but opinions might differ.

Most importantly switch `x` and `y` in the model definition so the model works correctly.
Removed some superfluous converting and simplified DataFrames syntax (I find `df2.weight` easier to read than `df2[:, :weight]` but opinions might differ.
@goedman goedman merged commit b5ded30 into StatisticalRethinkingJulia:master May 9, 2020
@goedman
Copy link
Member

goedman commented May 9, 2020

Thanks @karajan9 ! Merged.

@karajan9 karajan9 deleted the patch-2 branch May 10, 2020 07:46
@goedman
Copy link
Member

goedman commented May 10, 2020

Hi @karajan9 Can I ask what your goals are? Are you primarily interested in getting the models running or in the StatisticalRethinking added value of regression modeling?

If it is the latter I could set up a StatisticalRethinking branch where we would completely replace Stan by Turing. That is of course a lot more work, lots of mapping of Turing results to DataFrames and plotting, etc. Or we could redefine the contents of TuringModels.jl.

At some point I would go that direction anyway, but right now pretty busy with the causal modeling stuff.

@karajan9
Copy link
Contributor Author

karajan9 commented May 10, 2020

Hi!
I'm not quite sure what you mean by

Are you primarily interested in getting the models running or in the StatisticalRethinking added value of regression modeling?

?

As I wrote in #18 I'm going through the book, trying to translate the R code (this is where I work with the repo a lot), and working through the exercises.
Since I will be working with the code a lot anyway I'd be happy to help improve this repo, in one way or the other.

@goedman
Copy link
Member

goedman commented May 11, 2020

What I meant was in the StatisticalRethinking.jl repo most effort is on analyzing and working with the results of mcmc simulations while repos such as TuringModels.jl right now just contain a subset of the models.

Ultimately I would like to end up with StatisticalRethinking.jl to provide a set of methods (such as plotcoef, precis, plotbounds, link, quap etc which are useful for all 3 ...Models.jl repos.

From #18 I indeed had the impression you wanted to go beyond just the models. Why don't I send you an invite to the StatisticalRethinkingJulia organization and see where your effort take TuringModels.jl?

@karajan9
Copy link
Contributor Author

Ah yes. So far I'm only up to chapter 3 so I haven't met many of those tools yet. That also means that I'm not really familiar with how things are in that regard in this repo or what worthwhile improvements might be.

I'm a little worried if I'm able to help because while I have some Julia experience, I have very little experience in Turing, Bayesian modelling, StatisticalRethinking.jl, the book, or developing a package. I'd be happy to try but it might be rocky at first.

I guess before being able to do anything beyond some basic improvements I'd have to grasp the status quo so I get a better understanding what your goals are.
As soon as I manage to set up 2FA I'll look at the invite.

@ym-han
Copy link

ym-han commented May 12, 2020

Ah yes. So far I'm only up to chapter 3 so I haven't met many of those tools yet. That also means that I'm not really familiar with how things are in that regard in this repo or what worthwhile improvements might be.

I'm a little worried if I'm able to help because while I have some Julia experience, I have very little experience in Turing, Bayesian modelling, StatisticalRethinking.jl, the book, or developing a package. I'd be happy to try but it might be rocky at first.

I guess before being able to do anything beyond some basic improvements I'd have to grasp the status quo so I get a better understanding what your goals are.
As soon as I manage to set up 2FA I'll look at the invite.

This is somewhat off-topic, but: karajan, I'm also interested in working through Statistical Rethinking using Turing, as a way to learn both Bayesian statistics and Turing (though I'll probably won't be able to start till late this week or next week). Would you be interested in collaborating / sharing notes / talking about difficult parts or how to adapt it to Turing etc?

I'm on both slack and Zulip

@torkar
Copy link
Contributor

torkar commented May 12, 2020

Hi, after @trappmartin updated the models last week, to the latest Turing version, most of them are now in good shape. For Edition 2 there are

  1. some new models, and
  2. several of the models have been slightly updated (e.g., new priors etc.)

I asked @goedman before, but Rob, would it be sane to simply make a 2ed branch which can start from the master branch?

@karajan9
Copy link
Contributor Author

@ym-han sure, that sounds great! You can find me as Karajan or Jens on Slack or Zulip, feel free to reach out there.

@trappmartin
Copy link
Collaborator

I think starting a branch of 2ed sounds like a decent plan for now.

@goedman
Copy link
Member

goedman commented May 12, 2020

It's perfectly fine to use a 2ed branch.

I wonder if there is a need to keep the models in the 1st edition of the book around. Thus I'd assumed new priors, new models, etc. would end up in the released version as they become available.

@torkar
Copy link
Contributor

torkar commented May 12, 2020

Yeah, maybe you're right @goedman, just push for 2nd edition is probably a good option also :)

@goedman
Copy link
Member

goedman commented May 12, 2020

@karajan9 & @ym-han

Whenever your collaboration/discussions find areas where we can improve either StatisticalRethinking.jl or any of the ...Models.jl repos, please file an issue and/or pull request in the appropriate repo.

My experience with Slack has been that after a few weeks the history was typically gone.

@karajan9
Copy link
Contributor Author

please file an issue and/or pull request in the appropriate repo

Yes, will do. I have lost too much to the sands of slack to let that happen again :-D

I guess you'd want to discuss something like a roadmap in the issue above? I haven't found one yet but I assume it'd make contributing easier (not just for me).

@goedman
Copy link
Member

goedman commented May 12, 2020

Thank you.

Yes, I'm very interested in feedback on the above idea (repeated now in StatisticalRethinkingJulia/StatisticalRethinking.jl#92 (comment)) (if that is what you mean by roadmap).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants