Delete unused methods

mrigger · mrigger · commit 49e4a1741352 · 2020-08-29T09:23:11.000+02:00
Detected using http://www.ucdetector.org/.
diff --git a/src/sqlancer/Main.java b/src/sqlancer/Main.java
@@ -186,15 +186,6 @@ public void writeCurrentNoLineBreak(String queryString) {
             write(queryString, "");
         }
 
-        public void logRowNotFound(StateToReproduce state) {
-            printState(getLogFileWriter(), state);
-            try {
-                getLogFileWriter().flush();
-            } catch (IOException e) {
-                throw new AssertionError(e);
-            }
-        }
-
         public void logException(Throwable reduce, StateToReproduce state) {
             String stackTrace = getStackTrace(reduce);
             FileWriter logFileWriter2 = getLogFileWriter();
@@ -275,12 +266,6 @@ public void incrementCreateDatabase() {
 
     }
 
-    public static void printArray(Object... arr) {
-        for (Object o : arr) {
-            System.out.println(o);
-        }
-    }
-
     public static void main(String[] args) {
         System.exit(executeMain(args));
     }
diff --git a/src/sqlancer/Randomly.java b/src/sqlancer/Randomly.java
@@ -437,10 +437,6 @@ public static long getNonCachedInteger() {
         return getThreadRandom().get().nextLong();
     }
 
-    public static long getPositiveNonCachedInteger() {
-        return getNextLong(1, Long.MAX_VALUE);
-    }
-
     public static long getPositiveOrZeroNonCachedInteger() {
         return getNextLong(0, Long.MAX_VALUE);
     }
diff --git a/src/sqlancer/StateToReproduce.java b/src/sqlancer/StateToReproduce.java
@@ -18,14 +18,8 @@ public class StateToReproduce {
 
     protected long seedValue;
 
-    public String values;
-
     String exception;
 
-    public String queryTargetedTablesString;
-
-    public String queryTargetedColumnsString;
-
     public OracleRunReproductionState localState;
 
     public StateToReproduce(String databaseName) {
@@ -114,10 +108,6 @@ public void executedWithoutError() {
             this.success = true;
         }
 
-        public void log(Query q) {
-            statements.add(q);
-        }
-
         public void log(String s) {
             statements.add(new QueryAdapter(s));
         }
diff --git a/src/sqlancer/citus/gen/CitusCommon.java b/src/sqlancer/citus/gen/CitusCommon.java
@@ -2,9 +2,6 @@
 
 import sqlancer.citus.CitusBugs;
 import sqlancer.common.query.ExpectedErrors;
-import sqlancer.postgres.PostgresGlobalState;
-import sqlancer.postgres.PostgresSchema.PostgresTable;
-import sqlancer.postgres.gen.PostgresCommon;
 
 public final class CitusCommon {
 
@@ -73,10 +70,4 @@ public static void addCitusErrors(ExpectedErrors errors) {
         }
     }
 
-    public static void addTableConstraint(StringBuilder sb, PostgresTable table, PostgresGlobalState globalState,
-            ExpectedErrors errors) {
-        PostgresCommon.addTableConstraint(sb, table, globalState, errors);
-        CitusCommon.addCitusErrors(errors);
-    }
-
 }
diff --git a/src/sqlancer/cockroachdb/ast/CockroachDBAggregate.java b/src/sqlancer/cockroachdb/ast/CockroachDBAggregate.java
@@ -78,10 +78,6 @@ public static List<CockroachDBAggregateFunction> getAggregates(CockroachDBDataTy
             this.supportedReturnTypes = supportedReturnTypes.clone();
         }
 
-        public static CockroachDBAggregateFunction getRandom() {
-            return Randomly.fromOptions(values());
-        }
-
         public static CockroachDBAggregateFunction getRandomMetamorphicOracle() {
             // not: VARIANCE, STDDEV, SQRDIFF
             return Randomly.fromOptions(SUM, SUM_INT, MIN, MAX, XOR_AGG, BIT_AND, BIT_OR, BOOL_AND, BOOL_OR, COUNT, AVG,
diff --git a/src/sqlancer/cockroachdb/ast/CockroachDBUnaryArithmeticOperation.java b/src/sqlancer/cockroachdb/ast/CockroachDBUnaryArithmeticOperation.java
@@ -1,6 +1,5 @@
 package sqlancer.cockroachdb.ast;
 
-import sqlancer.Randomly;
 import sqlancer.cockroachdb.ast.CockroachDBUnaryArithmeticOperation.CockroachDBUnaryAritmeticOperator;
 import sqlancer.common.ast.BinaryOperatorNode.Operator;
 import sqlancer.common.ast.UnaryOperatorNode;
@@ -17,10 +16,6 @@ public enum CockroachDBUnaryAritmeticOperator implements Operator {
             this.textRepr = textRepr;
         }
 
-        public static CockroachDBUnaryAritmeticOperator getRandom() {
-            return Randomly.fromOptions(values());
-        }
-
         @Override
         public String getTextRepresentation() {
             return textRepr;
diff --git a/src/sqlancer/cockroachdb/ast/CockroachDBUnaryPostfixOperation.java b/src/sqlancer/cockroachdb/ast/CockroachDBUnaryPostfixOperation.java
@@ -1,6 +1,5 @@
 package sqlancer.cockroachdb.ast;
 
-import sqlancer.Randomly;
 import sqlancer.cockroachdb.ast.CockroachDBUnaryPostfixOperation.CockroachDBUnaryPostfixOperator;
 import sqlancer.common.ast.BinaryOperatorNode.Operator;
 import sqlancer.common.ast.UnaryOperatorNode;
@@ -21,10 +20,6 @@ public enum CockroachDBUnaryPostfixOperator implements Operator {
             this.s = s;
         }
 
-        public static CockroachDBUnaryPostfixOperator getRandom() {
-            return Randomly.fromOptions(values());
-        }
-
         @Override
         public String getTextRepresentation() {
             return s;
diff --git a/src/sqlancer/common/schema/AbstractTable.java b/src/sqlancer/common/schema/AbstractTable.java
@@ -2,7 +2,6 @@
 
 import java.util.Collections;
 import java.util.List;
-import java.util.function.Function;
 import java.util.stream.Collectors;
 
 import sqlancer.GlobalState;
@@ -60,10 +59,6 @@ public String getColumnsAsString() {
         return columns.stream().map(c -> c.getName()).collect(Collectors.joining(", "));
     }
 
-    public String getColumnsAsString(Function<C, String> function) {
-        return columns.stream().map(function).collect(Collectors.joining(", "));
-    }
-
     public C getRandomColumn() {
         return Randomly.fromList(columns);
     }
diff --git a/src/sqlancer/common/schema/AbstractTables.java b/src/sqlancer/common/schema/AbstractTables.java
@@ -30,11 +30,6 @@ public List<C> getColumns() {
         return columns;
     }
 
-    public String columnNamesAsString() {
-        return getColumns().stream().map(t -> t.getTable().getName() + "." + t.getName())
-                .collect(Collectors.joining(", "));
-    }
-
     public String columnNamesAsString(Function<C, String> function) {
         return getColumns().stream().map(function).collect(Collectors.joining(", "));
     }
diff --git a/src/sqlancer/duckdb/DuckDBSchema.java b/src/sqlancer/duckdb/DuckDBSchema.java
@@ -34,11 +34,6 @@ public static class DuckDBCompositeDataType {
 
         private final int size;
 
-        public DuckDBCompositeDataType(DuckDBDataType dataType) {
-            this.dataType = dataType;
-            this.size = -1;
-        }
-
         public DuckDBCompositeDataType(DuckDBDataType dataType, int size) {
             this.dataType = dataType;
             this.size = size;
@@ -78,10 +73,6 @@ public static DuckDBCompositeDataType getRandom() {
             return new DuckDBCompositeDataType(type, size);
         }
 
-        public static DuckDBCompositeDataType getInt(int size) {
-            return new DuckDBCompositeDataType(DuckDBDataType.INT, size);
-        }
-
         @Override
         public String toString() {
             switch (getPrimitiveDataType()) {
@@ -214,10 +205,6 @@ public DuckDBTable(String tableName, List<DuckDBColumn> columns, boolean isView)
             super(tableName, columns, Collections.emptyList(), isView);
         }
 
-        public boolean hasPrimaryKey() {
-            return getColumns().stream().anyMatch(c -> c.isPrimaryKey());
-        }
-
     }
 
     public static DuckDBSchema fromConnection(Connection con, String databaseName) throws SQLException {
diff --git a/src/sqlancer/mariadb/ast/MariaDBConstant.java b/src/sqlancer/mariadb/ast/MariaDBConstant.java
@@ -91,10 +91,6 @@ public static MariaDBTextConstant createTextConstant(String text) {
         return new MariaDBTextConstant(text);
     }
 
-    public static MariaDBDoubleConstant createDoubleConstant(double val) {
-        return new MariaDBDoubleConstant(val);
-    }
-
     public static MariaDBIntConstant createIntConstant(long val) {
         return new MariaDBIntConstant(val);
     }
diff --git a/src/sqlancer/mysql/MySQLProvider.java b/src/sqlancer/mysql/MySQLProvider.java
@@ -2,7 +2,6 @@
 
 import java.sql.Connection;
 import java.sql.DriverManager;
-import java.sql.ResultSet;
 import java.sql.SQLException;
 import java.sql.Statement;
 
@@ -14,7 +13,6 @@
 import sqlancer.common.query.Query;
 import sqlancer.common.query.QueryAdapter;
 import sqlancer.common.query.QueryProvider;
-import sqlancer.mysql.MySQLSchema.MySQLTable;
 import sqlancer.mysql.gen.MySQLAlterTable;
 import sqlancer.mysql.gen.MySQLDeleteGenerator;
 import sqlancer.mysql.gen.MySQLDropIndex;
@@ -149,15 +147,6 @@ public void generateDatabase(MySQLGlobalState globalState) throws SQLException {
         se.executeStatements();
     }
 
-    public static int getNrRows(Connection con, MySQLTable table) throws SQLException {
-        try (Statement s = con.createStatement()) {
-            try (ResultSet query = s.executeQuery("SELECT COUNT(*) FROM " + table.getName())) {
-                query.next();
-                return query.getInt(1);
-            }
-        }
-    }
-
     @Override
     public Connection createDatabase(MySQLGlobalState globalState) throws SQLException {
         String databaseName = globalState.getDatabaseName();
diff --git a/src/sqlancer/mysql/MySQLSchema.java b/src/sqlancer/mysql/MySQLSchema.java
@@ -177,10 +177,6 @@ public enum MySQLEngine {
                 this.s = s;
             }
 
-            String getTextRepresentation() {
-                return s;
-            }
-
             public static MySQLEngine get(String val) {
                 return Stream.of(values()).filter(engine -> engine.s.equalsIgnoreCase(val)).findFirst().get();
             }
diff --git a/src/sqlancer/mysql/ast/MySQLConstant.java b/src/sqlancer/mysql/ast/MySQLConstant.java
@@ -441,16 +441,6 @@ public String toString() {
 
     public abstract MySQLConstant isEquals(MySQLConstant rightVal);
 
-    public MySQLConstant isEqualsNullSafe(MySQLConstant rightVal) {
-        if (isNull()) {
-            return MySQLConstant.createBoolean(rightVal.isNull());
-        } else if (rightVal.isNull()) {
-            return MySQLConstant.createFalse();
-        } else {
-            return isEquals(rightVal);
-        }
-    }
-
     public abstract MySQLConstant castAs(CastType type);
 
     public abstract String castAsString();
diff --git a/src/sqlancer/mysql/gen/MySQLInsertGenerator.java b/src/sqlancer/mysql/gen/MySQLInsertGenerator.java
@@ -17,7 +17,6 @@ public class MySQLInsertGenerator {
 
     private final MySQLTable table;
     private final StringBuilder sb = new StringBuilder();
-    boolean canFail;
     private final ExpectedErrors errors = new ExpectedErrors();
     private final MySQLGlobalState globalState;
 
@@ -35,7 +34,6 @@ public static Query insertRow(MySQLGlobalState globalState) throws SQLException
     }
 
     private Query generateReplace() {
-        canFail = true;
         sb.append("REPLACE");
         if (Randomly.getBoolean()) {
             sb.append(" ");
@@ -53,8 +51,6 @@ private Query generateInsert() {
         }
         if (Randomly.getBoolean()) {
             sb.append(" IGNORE");
-        } else {
-            canFail = true;
         }
         return generateInto();
     }
diff --git a/src/sqlancer/postgres/PostgresVisitor.java b/src/sqlancer/postgres/PostgresVisitor.java
@@ -120,13 +120,6 @@ static String asExpectedValues(PostgresExpression expr) {
         return v.get();
     }
 
-    static String getExpressionAsString(PostgresGlobalState globalState, PostgresDataType type) {
-        PostgresExpression expression = PostgresExpressionGenerator.generateExpression(globalState, type);
-        PostgresToStringVisitor visitor = new PostgresToStringVisitor();
-        visitor.visit(expression);
-        return visitor.get();
-    }
-
     static String getExpressionAsString(PostgresGlobalState globalState, PostgresDataType type,
             List<PostgresColumn> columns) {
         PostgresExpression expression = PostgresExpressionGenerator.generateExpression(globalState, columns, type);
diff --git a/src/sqlancer/postgres/ast/PostgresAggregate.java b/src/sqlancer/postgres/ast/PostgresAggregate.java
@@ -28,14 +28,6 @@ public enum PostgresAggregateFunction {
             this.supportedReturnTypes = supportedReturnTypes.clone();
         }
 
-        public static PostgresAggregateFunction getRandom() {
-            return Randomly.fromOptions(values());
-        }
-
-        public static PostgresAggregateFunction getRandom(PostgresDataType type) {
-            return Randomly.fromOptions(values());
-        }
-
         public List<PostgresDataType> getTypes(PostgresDataType returnType) {
             return Arrays.asList(returnType);
         }
diff --git a/src/sqlancer/postgres/ast/PostgresColumnValue.java b/src/sqlancer/postgres/ast/PostgresColumnValue.java
@@ -23,10 +23,6 @@ public PostgresConstant getExpectedValue() {
         return expectedValue;
     }
 
-    public static PostgresColumnValue create(PostgresColumn c) {
-        return new PostgresColumnValue(c, null);
-    }
-
     public static PostgresColumnValue create(PostgresColumn c, PostgresConstant expected) {
         return new PostgresColumnValue(c, expected);
     }
diff --git a/src/sqlancer/postgres/ast/PostgresFunction.java b/src/sqlancer/postgres/ast/PostgresFunction.java
@@ -1,6 +1,5 @@
 package sqlancer.postgres.ast;
 
-import sqlancer.Randomly;
 import sqlancer.postgres.PostgresSchema.PostgresDataType;
 
 public class PostgresFunction implements PostgresExpression {
@@ -225,26 +224,12 @@ public PostgresDataType[] getRandomTypes(int nr) {
             return types;
         }
 
-        public PostgresDataType[] getType(int nr, PostgresDataType type) {
-            PostgresDataType[] types = new PostgresDataType[nr];
-            for (int i = 0; i < types.length; i++) {
-                types[i] = type;
-            }
-            return types;
-        }
-
         PostgresFunctionWithResult(int nrArgs, String functionName) {
             this.nrArgs = nrArgs;
             this.functionName = functionName;
             this.variadic = false;
         }
 
-        PostgresFunctionWithResult(int nrArgs, String functionName, boolean variadic) {
-            this.nrArgs = nrArgs;
-            this.functionName = functionName;
-            this.variadic = variadic;
-        }
-
         /**
          * Gets the number of arguments if the function is non-variadic. If the function is variadic, the minimum number
          * of arguments is returned.
@@ -257,10 +242,6 @@ public int getNrArgs() {
 
         public abstract PostgresConstant apply(PostgresConstant[] evaluatedArgs, PostgresExpression... args);
 
-        public static PostgresFunctionWithResult getRandomFunction() {
-            return Randomly.fromOptions(values());
-        }
-
         @Override
         public String toString() {
             return functionName;
diff --git a/src/sqlancer/postgres/gen/PostgresExpressionGenerator.java b/src/sqlancer/postgres/gen/PostgresExpressionGenerator.java
diff --git a/src/sqlancer/sqlite3/oracle/SQLite3PivotedQuerySynthesisOracle.java b/src/sqlancer/sqlite3/oracle/SQLite3PivotedQuerySynthesisOracle.java

Original file line number	Diff line number	Diff line change
`@@ -437,10 +437,6 @@ public static long getNonCachedInteger() {`
`437`	`437`	`return getThreadRandom().get().nextLong();`
`438`	`438`	`}`
`439`	`439`
`440`		`- public static long getPositiveNonCachedInteger() {`
`441`		`- return getNextLong(1, Long.MAX_VALUE);`
`442`		`- }`
`443`		`-`
`444`	`440`	`public static long getPositiveOrZeroNonCachedInteger() {`
`445`	`441`	`return getNextLong(0, Long.MAX_VALUE);`
`446`	`442`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,9 +2,6 @@`
`2`	`2`
`3`	`3`	`import sqlancer.citus.CitusBugs;`
`4`	`4`	`import sqlancer.common.query.ExpectedErrors;`
`5`		`-import sqlancer.postgres.PostgresGlobalState;`
`6`		`-import sqlancer.postgres.PostgresSchema.PostgresTable;`
`7`		`-import sqlancer.postgres.gen.PostgresCommon;`
`8`	`5`
`9`	`6`	`public final class CitusCommon {`
`10`	`7`
`@@ -73,10 +70,4 @@ public static void addCitusErrors(ExpectedErrors errors) {`
`73`	`70`	`}`
`74`	`71`	`}`
`75`	`72`
`76`		`- public static void addTableConstraint(StringBuilder sb, PostgresTable table, PostgresGlobalState globalState,`
`77`		`- ExpectedErrors errors) {`
`78`		`- PostgresCommon.addTableConstraint(sb, table, globalState, errors);`
`79`		`- CitusCommon.addCitusErrors(errors);`
`80`		`- }`
`81`		`-`
`82`	`73`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,11 +30,6 @@ public List<C> getColumns() {`
`30`	`30`	`return columns;`
`31`	`31`	`}`
`32`	`32`
`33`		`- public String columnNamesAsString() {`
`34`		`- return getColumns().stream().map(t -> t.getTable().getName() + "." + t.getName())`
`35`		`- .collect(Collectors.joining(", "));`
`36`		`- }`
`37`		`-`
`38`	`33`	`public String columnNamesAsString(Function<C, String> function) {`
`39`	`34`	`return getColumns().stream().map(function).collect(Collectors.joining(", "));`
`40`	`35`	`}`