Bug #18636874 PASSWORD VALIDATE PLUGIN: DICTIONARY CHECK MISBEHAVES WITH GOOD HEX INPUT

Marcin Babij · Marcin Babij · commit d9400c80e4cc · 2015-07-12T12:38:39.000+02:00
Running PASSWORD on non-text can lead to memory access problems. This is due to std::string being constructed on the buffer, but it ignore length of the buffer.
diff --git a/plugin/password_validation/validate_password.cc b/plugin/password_validation/validate_password.cc
@@ -227,7 +227,7 @@ static int validate_dictionary_check(mysql_string_handle password)
   mysql_string_free(lower_string_handle);
   int substr_pos= 0;
   int substr_length= length;
-  string_type password_str= (const char *)buffer;
+  string_type password_str= string_type((const char *)buffer, length);
   string_type password_substr;
   set_type::iterator itr;
   /*  
