Bug #19953365 MY_PRINT_DEFAULTS DOES NOT MASK PASSWORDS

Arun Kuruvila · Arun Kuruvila · commit 87d2cb669e6e · 2015-04-16T14:37:20.000+05:30
Description : "my_print_defaults" does not mask the
password while printing it.

Analysis : "my_print_defaults" does not mask the password
value before printing while displaying all the config param
values.

Fix : In "my_print_defaults", the password arguments are
masked by default while printing. An new  option,
"--show" has been introduced in this utility which is used
to print passwords without masking.

NOTE : mtr test case not added since '--password' option's
value cannot be specified at the command line.
diff --git a/extra/my_print_defaults.c b/extra/my_print_defaults.c
@@ -1,6 +1,6 @@
 
 /*
-   Copyright (c) 2000, 2012, Oracle and/or its affiliates. All rights reserved.
+   Copyright (c) 2000, 2015, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -32,6 +32,7 @@
 
 const char *config_file="my";			/* Default config file */
 static char *my_login_path;
+static my_bool *show_passwords;
 uint verbose= 0, opt_defaults_file_used= 0;
 const char *default_dbug_option="d:t:o,/tmp/my_print_defaults.trace";
 
@@ -87,6 +88,9 @@ static struct my_option my_long_options[] =
   {"login-path", 'l', "Path to be read from under the login file.",
    &my_login_path, &my_login_path, 0, GET_STR, REQUIRED_ARG,
    0, 0, 0, 0, 0, 0},
+  {"show", 's', "Show passwords in plain text.",
+   &show_passwords, &show_passwords, 0, GET_BOOL, NO_ARG,
+   0, 0, 0, 0, 0, 0},
   {"help", '?', "Display this help message and exit.",
    0, 0, 0, GET_NO_ARG, NO_ARG, 0, 0, 0, 0, 0, 0},
   {"verbose", 'v', "Increase the output level",
@@ -203,7 +207,12 @@ int main(int argc, char **argv)
 
   for (argument= arguments+1 ; *argument ; argument++)
     if (!my_getopt_is_args_separator(*argument))           /* skip arguments separator */
-      puts(*argument);
+    {
+      if (!(show_passwords) && strncmp(*argument, "--password", 10) == 0)
+        puts("--password=*****");
+      else
+        puts(*argument);
+    }
   my_free(load_default_groups);
   free_defaults(arguments);
 
