Bug#18284273: MYSQLDUMP SILENTLY QUITS WHEN IT ENCOUNTERS AN

Arun Kuruvila · Arun Kuruvila · commit 13d0b98c77d5 · 2016-04-13T10:59:26.000+05:30
ERROR.

Description:- The client utility, "mysqldump" fails silently
without printing any error message when it encounters an
error while executing FLUSH LOGS.

Analysis:- "mysqldump" uses the C API, "mysql_refresh()", to
flush the logs. Currently no error messages are printed upon
"mysql_refresh()" failure in "mysqldump".

Fix:- Proper error messages are printed upon "mysql_refresh()"
failure.

NOTE:- mtr test case is not added since its difficult to
simulate an error for "mysql_refresh()" through mtr.
diff --git a/client/mysqldump.c b/client/mysqldump.c
@@ -5825,7 +5825,10 @@ int main(int argc, char **argv)
     if (flush_logs || opt_delete_master_logs)
     {
       if (mysql_refresh(mysql, REFRESH_LOG))
+      {
+        DB_error(mysql, "when doing refresh");
         goto err;
+      }
       verbose_msg("-- main : logs flushed successfully!\n");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -5825,7 +5825,10 @@ int main(int argc, char **argv)`
`5825`	`5825`	`if (flush_logs \|\| opt_delete_master_logs)`
`5826`	`5826`	`{`
`5827`	`5827`	`if (mysql_refresh(mysql, REFRESH_LOG))`
	`5828`	`+ {`
	`5829`	`+ DB_error(mysql, "when doing refresh");`
`5828`	`5830`	`goto err;`
	`5831`	`+ }`
`5829`	`5832`	`verbose_msg("-- main : logs flushed successfully!\n");`
`5830`	`5833`	`}`
`5831`	`5834`