Prevent AIOOBE in error table

JakubValtar · JakubValtar · commit 2d6480363c6f · 2015-09-26T10:11:11.000-04:00
If the error checker updates the table between the click and invocation
of the click event listener, selection will be cleared and click index
will be -1. Checking if the index is valid before using it.
diff --git a/app/src/processing/app/ui/ErrorTable.java b/app/src/processing/app/ui/ErrorTable.java
@@ -105,25 +105,25 @@ public ErrorTable(final Editor editor) {
 //    }
 
 		addMouseListener(new MouseAdapter() {
-			@Override
-			synchronized public void mouseClicked(MouseEvent e) {
-				try {
-				  int row = ((ErrorTable) e.getSource()).getSelectedRow();
-					if (row >= 0 && row < getRowCount()) {
-					  Object data = getModel().getValueAt(row, DATA_COLUMN);
-					  int clickCount = e.getClickCount();
-					  if (clickCount == 1) {
-					    editor.errorTableClick(data);
-					  } else if (clickCount > 1) {
-					    editor.errorTableDoubleClick(data);
-					  }
+      @Override
+      synchronized public void mouseClicked(MouseEvent e) {
+        try {
+          int row = ((ErrorTable) e.getSource()).getSelectedRow();
+          if (row >= 0 && row < getRowCount()) {
+            Object data = getModel().getValueAt(row, DATA_COLUMN);
+            int clickCount = e.getClickCount();
+            if (clickCount == 1) {
+              editor.errorTableClick(data);
+            } else if (clickCount > 1) {
+              editor.errorTableDoubleClick(data);
+            }
 //				  editor.getErrorChecker().scrollToErrorLine(row);
-				  }
-				} catch (Exception ex) {
-					ex.printStackTrace();
-				}
-			}
-		});
+          }
+        } catch (Exception ex) {
+          ex.printStackTrace();
+        }
+      }
+    });
 
 		/*
 		addMouseMotionListener(new MouseMotionAdapter() {
