Skip to content

RTL Fix #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Hugo Tunius (k0nserv) merged 2 commits into from
Apr 14, 2017
Merged

RTL Fix #126

Hugo Tunius (k0nserv) merged 2 commits into from
Apr 14, 2017

Conversation

@Mehrdadmaskull
Copy link

@Mehrdadmaskull Mehrdad Ahmadi (Mehrdadmaskull) commented Apr 12, 2017

Fix for #109

@bogren
Copy link
Contributor

Emil Bogren (bogren) commented Apr 12, 2017

Hey thanks for the contribution, can you also add a note in CHANGELOG.md under the master section with a reference to the PR, and feel free to reference yourself.

@bogren Emil Bogren (bogren) mentioned this pull request Apr 12, 2017
Closed
@Mehrdadmaskull
Copy link
Author

Mehrdad Ahmadi (Mehrdadmaskull) commented Apr 14, 2017

Sorry for the other PR. Everything good now?

@k0nserv
Copy link
Contributor

Hugo Tunius (k0nserv) commented Apr 14, 2017 •
edited
Loading

Yeah looks good, thanks a lot Mehrdad Ahmadi (@Mehrdadmaskull) 😀

@k0nserv Hugo Tunius (k0nserv) merged commit 5a5cf8b into Skyscanner:master Apr 14, 2017
@Mehrdadmaskull
Copy link
Author

Mehrdad Ahmadi (Mehrdadmaskull) commented Apr 18, 2017

I just tried using SFLTF in yet another project, but couldn't find the recent changes to the master branch on the latest version installed from Cocoapods.

@k0nserv
Copy link
Contributor

Hugo Tunius (k0nserv) commented Apr 19, 2017

Hey Mehrdad Ahmadi (@Mehrdadmaskull) I had not gotten the time to release yet, however I've just done so. Give 3.1.0 a whirl and see if that doesn't work :)

@Mehrdadmaskull
Copy link
Author

Mehrdad Ahmadi (Mehrdadmaskull) commented Apr 22, 2017

Yea Hugo Tunius (@k0nserv), it works now! Thanks for the release

@iamir4g
Copy link

AmirFarahani (iamir4g) commented Dec 27, 2017

hi
my language phone is US but my app language Persian(RTL) how to change text alignment and placeholder?

@k0nserv
Copy link
Contributor

Hugo Tunius (k0nserv) commented Dec 28, 2017

AmirFarahani (@iamir4g) You need to have your phone in Persian for RTL to kick in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bogren Emil Bogren (bogren) bogren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mehrdadmaskull @bogren @k0nserv @iamir4g