Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #993 +/- ##
=========================================
+ Coverage 89.67% 89.77% +0.1%
=========================================
Files 1100 1098 -2
Lines 48926 48812 -114
Branches 3447 3433 -14
=========================================
- Hits 43872 43821 -51
+ Misses 4297 4285 -12
+ Partials 757 706 -51
Continue to review full report at Codecov.
|
antonfirsov
requested changes
Sep 1, 2019
Member
antonfirsov
left a comment
antonfirsov
left a comment
There was a problem hiding this comment.
A few concerns to address before we merge:
- There still might be a bug in Adaptive Histogram Equalization (see my comment). Do we want to wait until it gets fixed? Or just merge #984 as-is and open an issue?
- There are breaking changes in the packages we reference. We may want to enforce that a package update on SixLabors.ImageSharp and SixLabors.ImageSharp.Drawing also pulls the latest beta versions of Core, Fonts, and Shapes. I think we may want to specify a minimum version in
<PackageReference ... />, but I'm not familiar with this stuff.
| </PropertyGroup> | ||
|
|
||
| <!-- TODO: Include .NETSTANDARD2.1 when released--> | ||
| <PropertyGroup Condition=" $(TargetFramework.StartsWith('netcoreapp2')) "> |
Member
|
Ooops I did this by accident, we can revert it, if we want. |
Member
Author
|
@antonfirsov the minimum version for Core etc is specified already in the targets file. Let’s ship the equaliser as-is and raise a new ticket. |
| <PackageReference Update="SixLabors.Fonts" Version="1.0.0-beta0008" /> | ||
| <PackageReference Update="SixLabors.Shapes" Version="1.0.0-beta0008" /> | ||
| <PackageReference Update="SixLabors.Shapes.Text" Version="1.0.0-beta0007" /> | ||
| <PackageReference Update="SixLabors.Core" Version="1.0.0-beta0008" /> |
Member
There was a problem hiding this comment.
Thanks, totally missed this.
antonfirsov
approved these changes
Sep 1, 2019
|
Is there release schedule? I can't wait to use the new version |
Member
Author
|
@Rwing Most likely within the nest 12 hours. |
antonfirsov
pushed a commit
to antonfirsov/ImageSharp
that referenced
this pull request
Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I haven't enabled StyleCop for the tests yet as it's a days worth of work to cleanup all the issues there and it can wait until after the release. If someone can please review the linked PRs and see if they are in a mergeable state. The bug fix must definitely go in, the enhancement can possibly wait.