DEV-651 New BT command for factory test of RN4678#264
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Bluetooth command path intended to enable an RN4678 factory-test feature on supported Shimmer3 LogAndStream firmware.
Changes:
- Removes legacy pressure sampling-rate command constants from
ShimmerObjectand introduces a newSET_FEATUREBT opcode. - Adds a firmware/hardware capability gate (
isSupportedRn4678ErrorTest) to control when the feature can be used. - Adds a feature flag + enum and sends the new feature command during Shimmer3/3R initialization when enabled.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
ShimmerDriver/src/main/java/com/shimmerresearch/driver/ShimmerObject.java |
Removes old pressure sampling-rate command constants and adds the new SET_FEATURE command byte. |
ShimmerDriver/src/main/java/com/shimmerresearch/driver/ShimmerDevice.java |
Adds a version-gated capability check for the RN4678-related feature. |
ShimmerDriver/src/main/java/com/shimmerresearch/bluetooth/ShimmerBluetooth.java |
Adds feature toggle/enum, registers the new command, and sends the feature-enable command during initialization when applicable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ShimmerDriver/src/main/java/com/shimmerresearch/driver/ShimmerObject.java
Show resolved
Hide resolved
ShimmerDriver/src/main/java/com/shimmerresearch/bluetooth/ShimmerBluetooth.java
Show resolved
Hide resolved
ShimmerDriver/src/main/java/com/shimmerresearch/bluetooth/ShimmerBluetooth.java
Show resolved
Hide resolved
ShimmerDriver/src/main/java/com/shimmerresearch/bluetooth/ShimmerBluetooth.java
Outdated
Show resolved
Hide resolved
ShimmerDriver/src/main/java/com/shimmerresearch/driver/ShimmerDevice.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.