DEV-331 Fill in missing dock job error entry#263
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fills in a missing dock job error entry and makes related updates to dock/USB connection handling and device initialization tracking. The changes address ticket DEV-331.
Changes:
- Added missing error mapping for
SHIMMER_WRITE_DAUGHTER_CARD_IDdock job type - Extended dock configuration condition to include USB-plugged devices
- Added bluetooth version and mode read success tracking fields
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| DockJobDetails.java | Reorganized error code mappings and added the missing SHIMMER_WRITE_DAUGHTER_CARD_ID entry |
| AssembleShimmerConfig.java | Extended the docked device configuration condition to also check for USB-plugged devices |
| ShimmerDevice.java | Added mReadBtVerSuccess and mReadBtModeSuccess fields and reset them in setFirstDockRead() |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ShimmerDriver/src/main/java/com/shimmerresearch/driver/ShimmerDevice.java
Outdated
Show resolved
Hide resolved
…Device.java Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.