Skip to content

DEV-516 Improve logging of BLE Server and add shutdown hook #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmariapan-shimmer merged 2 commits into from
Oct 31, 2025
Merged

DEV-516 Improve logging of BLE Server and add shutdown hook #251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67ed359
DEV-516 improve logging of BLE Server - add exit code
jyong15 Oct 29, 2025
6c50e11
DEV-516 add shutdown hook to ensure BLE Server closes
jyong15 Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions ShimmerDriver/src/main/java/com/shimmerresearch/grpc/GrpcBLERadioByteTools.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,14 @@ public int startServer() throws Exception {
ProcessBuilder processBuilder = new ProcessBuilder(command);
processBuilder.redirectErrorStream(true); // Redirect standard error to the input stream
runningProcess = processBuilder.start();

// Add shutdown hook to ensure server is closed when Java app exits
try {
Runtime.getRuntime().addShutdownHook(shutdownHook);
} catch (IllegalStateException ignored) {
// JVM is already shutting down
}

Thread processThread = new Thread(() -> {
try (BufferedReader reader = new BufferedReader(new InputStreamReader(runningProcess.getInputStream()))) {
String line;
Expand All @@ -145,11 +153,35 @@ public int startServer() throws Exception {
e.printStackTrace();
}
});
runningProcess.onExit().thenAccept(p -> {
int code = p.exitValue();
System.err.println("[BLEGrpcServer] exited: code=" + code +
(code >= 128 ? " (likely signal " + (code - 128) + ")" : ""));
});

processThread.start();
return port;
// You can continue with other tasks here
}

private final Thread shutdownHook = new Thread(() -> {
Process p = runningProcess;
if (p == null) return;

try {
// Try graceful termination first
p.destroy(); // sends SIGTERM on Unix, WM_CLOSE/CTRL_BREAK semantics vary on Windows
if (!p.waitFor(3, java.util.concurrent.TimeUnit.SECONDS)) {
// Fall back to force kill
p.destroyForcibly();
p.waitFor(2, java.util.concurrent.TimeUnit.SECONDS);
}
} catch (InterruptedException ie) {
Thread.currentThread().interrupt();
} catch (Exception e) {
e.printStackTrace();
}
});

public void stopServer() {
if (runningProcess != null) {
Expand Down