Skip to content

sod_tube_zeus.py: Fix undefined name vx#988

Merged
tdavidcl merged 2 commits intoShamrock-code:mainfrom
cclauss:patch-1
May 24, 2025
Merged

sod_tube_zeus.py: Fix undefined name vx#988
tdavidcl merged 2 commits intoShamrock-code:mainfrom
cclauss:patch-1

Conversation

@cclauss
Copy link
Contributor

@cclauss cclauss commented May 24, 2025

% ruff check

Error: exemples/ci_tests/sod_tube_zeus.py:155:20: F821 Undefined name `vx`
Error: src/shambindings/src/run_ipython.py:15:58: F821 Undefined name `sys`

Undefined names can raise NameError at runtime.

cclauss added 2 commits May 24, 2025 10:21
@cclauss
sod_tube_zeus.py: Fix undefined name vx
dfade6a 
% `ruff check`
```
Error: exemples/ci_tests/sod_tube_zeus.py:155:20: F821 Undefined name `vx`
Error: src/shambindings/src/run_ipython.py:15:58: F821 Undefined name `sys`
```
@cclauss
run_ipython.py: import sys used on line 15
f8bcb45
@tdavidcl
Copy link
Member

tdavidcl commented May 24, 2025

Thanks a lot for the fixes. Weirdly, those went completely unnoticed until now 😅.
We should maybe add ruff to the CI.

@github-actions
Copy link
Contributor

github-actions bot commented May 24, 2025

Workflow report

workflow report corresponding to commit f8bcb45
Commiter email is [email protected]
Github page artifact URL Github page articact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 0
New warnings : 0
Warnings count : 5977 → 5977 (0.0%)

Detailed changes : 





      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
      



  

  @cclauss






  



    

      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        

  
    Contributor


        

  Author


    

  


  

    

      
          
      

      
            cclauss
  

      

      

      commented


        May 24, 2025


      
    


  





      


        



  
    

      
          
Ruff is great in pre-commit because it is written in Rust so it is always sub-second even on massive codebases.


      		
    

  





        


            

            
            

              
            

        

      


      

            
  
  

    
  
    
    

  

  

  


    












      

  
        

  

        

  tdavidcl
  

  
            

              
                    tdavidcl
  

              

              approved these changes


              
                  
                    May 24, 2025
                  
              
              
            


            



                
    View reviewed changes
  


            





          

  
  
  
              

                      

  

    

      

          
    
    

  


        
            
  
      
              Copy link

  

        
      

    


    

        

  
  Member


        

    

  


  

    

      
          @tdavidcl
      

      
            tdavidcl
  

      

      

      left a comment




      
    


  



                  

                      

  

  
 

  
    

    
Choose a reason for hiding this comment


    

      The reason will be displayed to describe this comment to others. Learn more.
    


    

      
      



  



  
    

      
LGTM !

      
    

  
  




                    

                  
  
  

    
  
    
    

  

  

  



                      

                    
                  








      

  
  
  




  








      

  
          
 
  

    
  

  


        
        @tdavidcl
  tdavidcl



        merged commit dacb43a
      into

      
  
    Shamrock-code:main
  


    May 24, 2025

      

        38 checks passed
      


      

        
  
          
  
    
    


  
      

  







  

  
  

  
      @cclauss
  cclauss


    
    deleted the
    
      
        patch-1
    
    branch

    May 24, 2025 15:23    
    




  

  

    
  


  

      


    @cclauss
cclauss



    mentioned this pull request
    
      May 24, 2025
    





  


  

      
   Merged

  







  




  



  
    
  
  

    

  tdavidcl 

      added a commit
      that referenced
      this pull request

    
      May 25, 2025
    
    

      


  

    

      


  

      
        @cclauss
      
        @tdavidcl
  





      

        
          pre-commit: Add ruff linter for Python code (#990)
        

          
            
          

      


      

          

    
    
    

  

    


      


      

          

    
    
    

  

  

    
  



      


      
      

        
          019ab85
        
      

    

  

    

      
As discussed in:
* #988 

# https://docs.astral.sh/ruff/linter

---------

Co-authored-by: David--Cléris Timothée <[email protected]>

    




    

  













  
  

    

      

  










  








  
      

  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment


  










      

  

    
    

    

  

    Reviewers
  


    


      

  

    


  
      @tdavidcl
  
    tdavidcl


    
      
        
      
    
    tdavidcl approved these changes




      






    
    
    

    

  


      
  

    Assignees
  



        


    No one assigned







      


  


  

    Labels
  



    

      

    in-review









      

  

    

        

    Projects
  


        




    None yet




  



      


  

    
  

    Milestone
  


      No milestone





    
      
          


  

    

      
        

          
  

    Development
  



            





Successfully merging this pull request may close these issues.





  
  



      
    

  




      

    

  
        

  

    

      2 participants
    

    

        
          @cclauss 
        
          @tdavidcl