Skip to content

[Ramses][solvergraph PR 3] replace ConsToPrim by solvergraph modules#962

Merged
tdavidcl merged 18 commits intoShamrock-code:mainfrom
tdavidcl:feat/remove-cons-to-prim
May 14, 2025
Merged

[Ramses][solvergraph PR 3] replace ConsToPrim by solvergraph modules#962
tdavidcl merged 18 commits intoShamrock-code:mainfrom
tdavidcl:feat/remove-cons-to-prim

Conversation

@tdavidcl
Copy link
Member

@tdavidcl tdavidcl commented May 9, 2025

No description provided.

@tdavidcl tdavidcl changed the title [Ramses] replace ConsToPrim by solvergraph modules [Ramses][solvergraph PR 3] replace ConsToPrim by solvergraph modules May 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 14, 2025

Workflow report

workflow report corresponding to commit bd04666
Commiter email is [email protected]
Github page artifact URL Github page articact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

/__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:25:10: error: 'shammodels/ramses/GhostZoneData.hpp' file not found [clang-diagnostic-error]
   25 | #include "shammodels/ramses/GhostZoneData.hpp"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

1 error generated.
Error while processing /__w/Shamrock/Shamrock/src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp.
Found compiler errors, but -fix-errors was not specified.
Fixes have NOT been applied.

Found compiler error(s).

Doxygen diff with main

Removed warnings : 101
New warnings : 82
Warnings count : 5951 → 5932 (-0.3%)

Detailed changes : 
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:28: warning: Compound shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:31: warning: Member Tscal (typedef) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:32: warning: Member Tgridscal (typedef) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:33: warning: Member dim (variable) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:34: warning: Member split_count (variable) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:36: warning: Member Config (typedef) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:37: warning: Member Storage (typedef) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:38: warning: Member u_morton (typedef) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:39: warning: Member AMRBlock (typedef) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:40: warning: Member OrientedAMRGraph (typedef) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:42: warning: Member context (variable) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:43: warning: Member solver_config (variable) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:44: warning: Member storage (variable) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:46: warning: Member ConsToPrim(ShamrockCtx &context, Config &solver_config, Storage &storage) (function) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:49: warning: Member cons_to_prim_gas_spans(shambase::DistributedData< shamrock::PatchDataFieldSpanPointer< Tscal > > &spans_rho, shambase::DistributedData< shamrock::PatchDataFieldSpanPointer< Tvec > > &spans_rhov, shambase::DistributedData< shamrock::PatchDataFieldSpanPointer< Tscal > > &spans_rhoe, shambase::DistributedData< shamrock::PatchDataFieldSpanPointer< Tvec > > &spans_vel, shambase::DistributedData< shamrock::PatchDataFieldSpanPointer< Tscal > > &spans_P, shambase::DistributedData< u32 > &sizes) (function) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:59: warning: Member cons_to_prim_dust_spans(shambase::DistributedData< shamrock::PatchDataFieldSpanPointer< Tscal > > &spans_rho_dust, shambase::DistributedData< shamrock::PatchDataFieldSpanPointer< Tvec > > &spans_rhov_dust, shambase::DistributedData< shamrock::PatchDataFieldSpanPointer< Tvec > > &spans_vel_dust, shambase::DistributedData< u32 > &sizes) (function) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:67: warning: Member cons_to_prim_gas() (function) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:68: warning: Member cons_to_prim_dust() (function) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:70: warning: Member reset_gas() (function) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/ConsToPrim.hpp:71: warning: Member reset_dust() (function) of class shammodels::basegodunov::modules::ConsToPrim is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:102: warning: Member rho_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:102: warning: Member rho_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:105: warning: Member rho_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:106: warning: Member vel_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:109: warning: Member vel_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:109: warning: Member vel_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:112: warning: Member vel_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:112: warning: Member vel_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:115: warning: Member vel_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:115: warning: Member vel_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:118: warning: Member vel_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:118: warning: Member vel_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:121: warning: Member vel_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:121: warning: Member vel_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:124: warning: Member vel_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:125: warning: Member press_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:128: warning: Member press_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:128: warning: Member press_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:131: warning: Member press_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:131: warning: Member press_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:134: warning: Member press_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:134: warning: Member press_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:137: warning: Member press_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:137: warning: Member press_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:140: warning: Member press_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:140: warning: Member press_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:143: warning: Member press_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:144: warning: Member flux_rho_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:147: warning: Member flux_rho_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:147: warning: Member flux_rho_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:150: warning: Member flux_rho_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:150: warning: Member flux_rho_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:153: warning: Member flux_rho_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:153: warning: Member flux_rho_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:156: warning: Member flux_rho_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:156: warning: Member flux_rho_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:159: warning: Member flux_rho_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:159: warning: Member flux_rho_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:162: warning: Member flux_rho_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:163: warning: Member flux_rhov_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:166: warning: Member flux_rhov_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:166: warning: Member flux_rhov_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:169: warning: Member flux_rhov_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:169: warning: Member flux_rhov_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:172: warning: Member flux_rhov_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:172: warning: Member flux_rhov_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:175: warning: Member flux_rhov_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:175: warning: Member flux_rhov_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:178: warning: Member flux_rhov_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:178: warning: Member flux_rhov_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:181: warning: Member flux_rhov_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:182: warning: Member flux_rhoe_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:185: warning: Member flux_rhoe_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:185: warning: Member flux_rhoe_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:188: warning: Member flux_rhoe_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:188: warning: Member flux_rhoe_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:191: warning: Member flux_rhoe_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:191: warning: Member flux_rhoe_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:194: warning: Member flux_rhoe_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:194: warning: Member flux_rhoe_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:197: warning: Member flux_rhoe_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:197: warning: Member flux_rhoe_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:199: warning: Member dtrho (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:200: warning: Member dtrhov (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:200: warning: Member flux_rhoe_face_zm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:201: warning: Member dtrhoe (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:202: warning: Member dtrho (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:203: warning: Member dtrhov (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:203: warning: Member rho_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:204: warning: Member dtrhoe (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:204: warning: Member rhov_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:205: warning: Member rhoe_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:206: warning: Member rho_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:207: warning: Member rhov_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:208: warning: Member rhoe_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:216: warning: Member rho_d_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:218: warning: Member rhov_d_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:219: warning: Member rho_d_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:221: warning: Member rhov_d_next_no_drag (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:364: warning: Member dtrho_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:366: warning: Member dtrhov_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:367: warning: Member dtrho_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:368: warning: Compound shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:369: warning: Member dtrhov_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:369: warning: Member interface (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:370: warning: Member neighbors (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:371: warning: Compound shammodels::basegodunov::SolverStorage::Timings is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:371: warning: Member io (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:372: warning: Member interface (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:373: warning: Member neighbors (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:374: warning: Member io (variable) of struct shammodels::basegodunov::SolverStorage::Timings is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:375: warning: Member timings_details (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:378: warning: Member timings_details (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:40: warning: Member Component (typedef) of namespace shammodels::basegodunov is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:40: warning: Member Component (typedef) of namespace shammodels::basegodunov is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:41: warning: Member Component (typedef) of namespace shammodels::basegodunov is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:41: warning: Member Component (typedef) of namespace shammodels::basegodunov is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:43: warning: Compound shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:44: warning: Compound shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:45: warning: Member Tscal (typedef) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:46: warning: Member Tgridscal (typedef) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:46: warning: Member Tscal (typedef) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:47: warning: Member Tgridscal (typedef) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:47: warning: Member dim (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:48: warning: Member dim (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:49: warning: Member RTree (typedef) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:50: warning: Member RTree (typedef) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:51: warning: Member block_counts_with_ghost (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:52: warning: Member block_counts_with_ghost (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:52: warning: Member refs_rho (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:53: warning: Member refs_rho (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:53: warning: Member refs_rhov (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:54: warning: Member refs_rhoe (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:54: warning: Member refs_rhov (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:55: warning: Member refs_rho_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:55: warning: Member refs_rhoe (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:56: warning: Member refs_rho_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:56: warning: Member refs_rhov_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:57: warning: Member refs_rhov_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:58: warning: Member vel (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:59: warning: Member press (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:59: warning: Member vel (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:60: warning: Member press (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:60: warning: Member vel_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:61: warning: Member vel_dust (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:62: warning: Member serial_patch_tree (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:63: warning: Member node_cons_to_prim (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:64: warning: Member ghost_zone_infos (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:65: warning: Member serial_patch_tree (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:66: warning: Member ghost_layout (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:67: warning: Member ghost_zone_infos (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:68: warning: Member merged_patchdata_ghost (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:69: warning: Member ghost_layout (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:70: warning: Member cell_infos (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:71: warning: Member merged_patchdata_ghost (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:72: warning: Member merge_patch_bounds (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:73: warning: Member cell_infos (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:73: warning: Member trees (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:75: warning: Member merge_patch_bounds (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:76: warning: Member trees (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:77: warning: Member cell_link_graph (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:79: warning: Member grad_rho (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:80: warning: Member cell_link_graph (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:80: warning: Member dx_v (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:81: warning: Member dy_v (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:82: warning: Member dz_v (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:82: warning: Member grad_rho (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:83: warning: Member dx_v (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:83: warning: Member grad_P (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:84: warning: Member dy_v (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:85: warning: Member dz_v (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:86: warning: Member grad_P (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:87: warning: Member rho_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:90: warning: Member rho_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:90: warning: Member rho_face_xp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:93: warning: Member rho_face_xm (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:93: warning: Member rho_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:96: warning: Member rho_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:96: warning: Member rho_face_yp (variable) of class shammodels::basegodunov::SolverStorage is not documented.
+ src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:99: warning: Member rho_face_ym (variable) of class shammodels::basegodunov::SolverStorage is not documented.
- src/shammodels/ramses/include/shammodels/ramses/modules/SolverStorage.hpp:99: warning: Member rho_face_zp (variable) of class shammodels::basegodunov::SolverStorage is not documented.

@tdavidcl tdavidcl merged commit 6cf4adf into Shamrock-code:main May 14, 2025
36 checks passed
@tdavidcl tdavidcl deleted the feat/remove-cons-to-prim branch May 14, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tdavidcl