Skip to content

[Patch] fix a missing const on PatchDataFieldSpan accessors#953

Merged
tdavidcl merged 2 commits intoShamrock-code:mainfrom
tdavidcl:fix/pdspan-const
May 7, 2025
Merged

[Patch] fix a missing const on PatchDataFieldSpan accessors#953
tdavidcl merged 2 commits intoShamrock-code:mainfrom
tdavidcl:fix/pdspan-const

Conversation

@tdavidcl
Copy link
Member

@tdavidcl tdavidcl commented May 7, 2025

No description provided.

@tdavidcl tdavidcl requested a review from Akos299 May 7, 2025 09:33
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Workflow report

workflow report corresponding to commit fe4763e
Commiter email is [email protected]

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 13
New warnings : 11
Warnings count : 5739 → 5737 (-0.0%)

Detailed changes : 
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:107: warning: Member access_t_pointer (variable) of namespace shamrock is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:107: warning: Member access_t_pointer (variable) of namespace shamrock is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:108: warning: Member access_t_span (variable) of namespace shamrock is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:108: warning: Member access_t_span (variable) of namespace shamrock is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:109: warning: Member access_t_pointer (variable) of namespace shamrock is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:109: warning: Member access_t_pointer (variable) of namespace shamrock is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:110: warning: Member access_t_span (variable) of namespace shamrock is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:110: warning: Member access_t_span (variable) of namespace shamrock is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:157: warning: Member is_pointer_access() (function) of class shamrock::PatchDataFieldSpan is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:159: warning: Member is_pointer_access() (function) of class shamrock::PatchDataFieldSpan is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:160: warning: Member is_span_access() (function) of class shamrock::PatchDataFieldSpan is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:162: warning: Member is_span_access() (function) of class shamrock::PatchDataFieldSpan is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:165: warning: The following parameter of shamrock::PatchDataFieldSpan::PatchDataFieldSpan(PatchDataField< T > &field_ref, u32 start, u32 count, SourceLocation loc=SourceLocation{}) is not documented:
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:167: warning: The following parameter of shamrock::PatchDataFieldSpan::PatchDataFieldSpan(PatchDataField< T > &field_ref, u32 start, u32 count, SourceLocation loc=SourceLocation{}) is not documented:
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:297: warning: Member get_read_access(sham::EventList &depends_list) -> const T *const (function) of class shamrock::PatchDataFieldSpan is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:299: warning: Member get_read_access(sham::EventList &depends_list) -> const T *const (function) of class shamrock::PatchDataFieldSpan is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:303: warning: Member get_write_access(sham::EventList &depends_list) -> T * (function) of class shamrock::PatchDataFieldSpan is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:305: warning: Member get_write_access(sham::EventList &depends_list) -> T * (function) of class shamrock::PatchDataFieldSpan is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:333: warning: Member PatchDataFieldSpanPointer (typedef) of namespace shamrock is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:333: warning: Member PatchDataFieldSpanPointer (typedef) of namespace shamrock is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:335: warning: Member PatchDataFieldSpanPointer (typedef) of namespace shamrock is not documented.
+ src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:335: warning: Member PatchDataFieldSpanPointer (typedef) of namespace shamrock is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:42: warning: Member operator[](u32 idx) const (function) of struct shamrock::details::PatchDataFieldSpan_access_rw_dyn_nvar is not documented.
- src/shamrock/include/shamrock/patch/PatchDataFieldSpan.hpp:54: warning: Member operator[](u32 idx) const (function) of struct shamrock::details::PatchDataFieldSpan_access_ro_dyn_nvar is not documented.

@tdavidcl tdavidcl merged commit 0deaa54 into Shamrock-code:main May 7, 2025
@tdavidcl tdavidcl deleted the fix/pdspan-const branch May 7, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Akos299 Akos299 Akos299 approved these changes

Assignees

No one assigned

Labels

in-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tdavidcl @Akos299