Skip to content

[Bindings] hide exe/pylib compile flags switch inside shambindings sources#860

Merged
tdavidcl merged 3 commits intoShamrock-code:mainfrom
tdavidcl:feat/bindings-hide-compile-flag
Mar 15, 2025
Merged

[Bindings] hide exe/pylib compile flags switch inside shambindings sources#860
tdavidcl merged 3 commits intoShamrock-code:mainfrom
tdavidcl:feat/bindings-hide-compile-flag

Conversation

@tdavidcl
Copy link
Member

No description provided.

@tdavidcl tdavidcl linked an issue Mar 14, 2025 that may be closed by this pull request
@github-actions
Copy link
Contributor

Workflow report

workflow report corresponding to commit 7132d27
Commiter email is [email protected]

Pre-commit check report

Pre-commit check: ✅

[WARNING] The 'rev' field of repo 'https://github.com/psf/black' appears to be a mutable reference (moving tag / branch).  Mutable references are never updated after first install and are not supported.  See https://pre-commit.com/#using-the-latest-version-for-a-repository for more details.  Hint: `pre-commit autoupdate` often fixes this.
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
black....................................................................Passed
isort....................................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with main

Removed warnings : 3
New warnings : 4
Warnings count : 5695 → 5696 (0.0%)

Detailed changes :
- src/main.cpp:54: warning: Member main(int argc, char *argv[]) (function) of file main.cpp is not documented.
+ src/main.cpp:59: warning: Member main(int argc, char *argv[]) (function) of file main.cpp is not documented.
- src/main_lib.cpp:20: warning: Member main_lib() (function) of file main_lib.cpp is not documented.
- src/main_test.cpp:29: warning: Member main(int argc, char *argv[]) (function) of file main_test.cpp is not documented.
+ src/main_test.cpp:34: warning: Member main(int argc, char *argv[]) (function) of file main_test.cpp is not documented.
+ src/shambindings/src/pybindings.cpp:64: warning: Member init_state (variable) of namespace shambindings is not documented.
+ src/shambindings/src/pybindings.cpp:67: warning: Member init(py::module &m) (function) of namespace shambindings is not documented.

@tdavidcl tdavidcl merged commit 19976b2 into Shamrock-code:main Mar 15, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bindings] hide SHAMROCK_LIB_BUILD inside shambindings sources

1 participant