Skip to content

[Backends] add lambda signature checking in kernel_call#723

Merged
tdavidcl merged 2 commits intomainfrom
feat/type-check-kernel-call
Dec 27, 2024
Merged

[Backends] add lambda signature checking in kernel_call#723
tdavidcl merged 2 commits intomainfrom
feat/type-check-kernel-call

Conversation

@tdavidcl
Copy link
Member

This PR add a check on the type signature of the lambda when invoking kernel_call.
This provides cleaner message suggesting the correct lambda signature if kernel_call fail to compile.

@github-actions
Copy link
Contributor

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed

Test pipeline can run.

@github-actions
Copy link
Contributor

Cland tidy diff report


Suggested changes

Detailed changes :

@github-actions
Copy link
Contributor

Doxygen diff with main

Removed warnings : 2
New warnings : 0
Warnings count : 5729 → 5727 (-0.0%)

Detailed changes :
- src/shambase/include/shambase/WithUUID.hpp:37: warning: Compound shambase::WithUUID is not documented.
- src/shambase/include/shambase/WithUUID.hpp:42: warning: included file Example is not found. Check your EXAMPLE_PATH

@tdavidcl tdavidcl merged commit 8451f4f into main Dec 27, 2024
@tdavidcl tdavidcl deleted the feat/type-check-kernel-call branch December 27, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant