Conversation
Contributor
|
Pre-commit check: ✅ Test pipeline can run. |
Contributor
Cland tidy diff reportSuggested changesDetailed changes : |
Contributor
Doxygen diff with
|
tdavidcl
added a commit
that referenced
this pull request
Dec 27, 2024
Fix compile error on recent clang (20+) introduced by #696.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add a
BufferMirrorutility. This is just a pointer to mirror data from aDeviceBufferwhich will write back changes on destruction.Typically to write data from the CPU one can do the following:
{ auto acc = f.get_buf().template mirror_to<sham::host>(); auto acc_xyz = xyz.get_buf().template mirror_to<sham::host>(); for (u32 i = 0; i < f.size(); i++) { Tvec position = acc_xyz[i]; acc[i] =function(position); } }