fix comments from review - adding null checks.

ali-hamud · ali-hamud · commit e72fcc1e456a · 2016-11-14T11:44:15.000+02:00
diff --git a/demo/code-demo/scripts/session_utils.js b/demo/code-demo/scripts/session_utils.js
@@ -38,22 +38,13 @@ function UpdateSessions() {
 
 function SetAccessTokenFromSession() {
     var sessionAccessToken = GetSession("accessToken");
-    if (sessionAccessToken)
-    {
-        $("#txtAccessToken").val(sessionAccessToken);
-    }
+    $("#txtAccessToken").val(sessionAccessToken);
 }
 
 function SetEmbedUrlFromSession() {    
     var sessionEmbedUrl = GetSession("embedUrl");
-    if (sessionEmbedUrl)
-    {
-        $("#txtReportEmbed").val(sessionEmbedUrl);
-    }
+    $("#txtReportEmbed").val(sessionEmbedUrl);
     
     var sessionEmbedId = GetSession("embedId");
-    if (sessionEmbedId)
-    {
-        $("#txtEmbedReportId").val(sessionEmbedId);
-    }
+    $("#txtEmbedReportId").val(sessionEmbedId);
 }
diff --git a/demo/code-demo/scripts/step_authorize.js b/demo/code-demo/scripts/step_authorize.js
@@ -1,6 +1,6 @@
 var embedWithSpecificReportDivExpanded = false;
 
-function ExpandEmbedWithSpecificReportDiv() {
+function ToggleEmbedWithSpecificReportDiv() {
     if (embedWithSpecificReportDivExpanded == true)
     {
         embedWithSpecificReportDivExpanded = false;
diff --git a/demo/code-demo/scripts/utils.js b/demo/code-demo/scripts/utils.js
@@ -11,7 +11,10 @@
     if (parts && parts.length > 0)
     {
         var guidParts = parts[parts.length  -1].split("&");
-        id = guidParts[0];
+        if (guidParts && guidParts.length > 0)
+        {
+            id = guidParts[0];
+        }
     }
     
     if (!id)
diff --git a/demo/code-demo/step_authorize.html b/demo/code-demo/step_authorize.html
@@ -3,7 +3,7 @@
     <h4>Sample Report</h4>
     To Embed using a sample report, you can just move to next step.<br/>
     <button id="nextStepWithSample" class="btn btn-primary" onclick="OpenEmbedStepWithSample()">Embed Sample Report</button><br/><br/><br/>
-    <a href="#" onclick="ExpandEmbedWithSpecificReportDiv()">Embed Your Own Report</a><br/>
+    <a href="#" onclick="ToggleEmbedWithSpecificReportDiv()">Embed Your Own Report</a><br/>
 </div>
 <div id="EmbedWithSpecificReportDiv" style="display: none;">
     <div class="line">
@@ -16,7 +16,7 @@ <h4>Prerequisites</h4>
     <br/>
     <div class="line">
         <h4>Flow</h4>
-        Once you have a report imported to PowerBI Workspace, you are ready to Embed it.<br/>
+        Once you have a report imported to PowerBI Workspace, you are ready to embed it.<br/>
         To Embed a report you need to get an Embed-Token. You can create this token in multiple ways:<br/>
         <ul>
             <li>Using <a href="https://github.com/Microsoft/PowerBI-cli">PowerBI-Cli</a> tool.<br/></li>

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`var embedWithSpecificReportDivExpanded = false;`
`2`	`2`
`3`		`-function ExpandEmbedWithSpecificReportDiv() {`
	`3`	`+function ToggleEmbedWithSpecificReportDiv() {`
`4`	`4`	`if (embedWithSpecificReportDivExpanded == true)`
`5`	`5`	`{`
`6`	`6`	`embedWithSpecificReportDivExpanded = false;`
Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,10 @@`
`11`	`11`	`if (parts && parts.length > 0)`
`12`	`12`	`{`
`13`	`13`	`var guidParts = parts[parts.length -1].split("&");`
`14`		`- id = guidParts[0];`
	`14`	`+ if (guidParts && guidParts.length > 0)`
	`15`	`+ {`
	`16`	`+ id = guidParts[0];`
	`17`	`+ }`
`15`	`18`	`}`
`16`	`19`
`17`	`20`	`if (!id)`