Skip to content

Commit 08e9d27

Browse files
author
Matt Mazzola
committed
Add comment explaining reason for service.wpmp being public.
1 parent c467732 commit 08e9d27

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

src/service.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,10 @@ export class Service implements IService {
9292

9393
/** List of components (Reports/Tiles) that have been embedded using this service instance. */
9494
private embeds: embed.Embed[];
95-
/** TODO: Look for way to make this private without sacraficing ease of maitenance. This should be private but in embed needs to call methods. */
96-
public hpm: hpm.HttpPostMessage;
97-
public wpmp: wpmp.WindowPostMessageProxy;
95+
/** TODO: Look for way to make hpm private without sacraficing ease of maitenance. This should be private but in embed needs to call methods. */
96+
hpm: hpm.HttpPostMessage;
97+
/** TODO: Look for way to make wpmp private. This is only public to allow stopping the wpmp in tests */
98+
wpmp: wpmp.WindowPostMessageProxy;
9899
private router: router.Router;
99100

100101
/**

0 commit comments

Comments
 (0)