Fix crash when rootViewController is nil during dismiss#1156
Open
AdrianCurtin wants to merge 1 commit intoSVProgressHUD:masterfrom
Open
Fix crash when rootViewController is nil during dismiss#1156AdrianCurtin wants to merge 1 commit intoSVProgressHUD:masterfrom
AdrianCurtin wants to merge 1 commit intoSVProgressHUD:masterfrom
Conversation
Added a nil check before calling setNeedsStatusBarAppearanceUpdate on rootViewController to prevent potential crashes when rootViewController is not set.
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash that occurs when SVProgressHUD is dismissed and the rootViewController is nil. The fix adds a defensive nil check before calling setNeedsStatusBarAppearanceUpdate on the rootViewController.
- Adds nil check for rootViewController before calling
setNeedsStatusBarAppearanceUpdate
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1155
Adds a nil check before calling
setNeedsStatusBarAppearanceUpdateon the rootViewController in the dismiss animation completion block.Problem
When SVProgressHUD is dismissed, the animation completion block retrieves the rootViewController and calls
setNeedsStatusBarAppearanceUpdateon it. If the rootViewController has been deallocated (e.g., during view controller transitions), this causes a crash.Solution
Simple nil check before the method call:
Testing