I need to remind myself to update Lib/test/test_compile.py to the version from CPython 3.11.

wow, this makes a lot of tests pass 😄

The following tests in test_compile can be marked as passing (i.e remove the # TODO: RUSTPYTHON comment and the expectedFailure decorator from the test function.

test_async_for (test.test_compile.TestStackSizeStability) ... unexpected success
test_async_for_else (test.test_compile.TestStackSizeStability) ... unexpected success
test_async_with (test.test_compile.TestStackSizeStability) ... unexpected success
test_for (test.test_compile.TestStackSizeStability) ... unexpected success
test_for_break_continue (test.test_compile.TestStackSizeStability) ... unexpected success
test_for_break_continue_inside_async_with_block (test.test_compile.TestStackSizeStability) ... unexpected success
test_for_break_continue_inside_except_block (test.test_compile.TestStackSizeStability) ... unexpected success
test_for_break_continue_inside_finally_block (test.test_compile.TestStackSizeStability) ... unexpected success
test_for_break_continue_inside_try_finally_block (test.test_compile.TestStackSizeStability) ... unexpected success
test_for_break_continue_inside_with_block (test.test_compile.TestStackSizeStability) ... unexpected success
test_for_else (test.test_compile.TestStackSizeStability) ... unexpected success
test_if (test.test_compile.TestStackSizeStability) ... unexpected success
test_if_else (test.test_compile.TestStackSizeStability) ... unexpected success
test_return_inside_async_with_block (test.test_compile.TestStackSizeStability) ... unexpected success
test_return_inside_except_block (test.test_compile.TestStackSizeStability) ... unexpected success
test_return_inside_finally_block (test.test_compile.TestStackSizeStability) ... unexpected success
test_return_inside_try_finally_block (test.test_compile.TestStackSizeStability) ... unexpected success
test_return_inside_with_block (test.test_compile.TestStackSizeStability) ... unexpected success
test_try_except_as (test.test_compile.TestStackSizeStability) ... unexpected success
test_try_except_bare (test.test_compile.TestStackSizeStability) ... unexpected success
test_try_except_qualified (test.test_compile.TestStackSizeStability) ... unexpected success
test_try_finally (test.test_compile.TestStackSizeStability) ... unexpected success
test_while_else (test.test_compile.TestStackSizeStability) ... unexpected success
test_with (test.test_compile.TestStackSizeStability) ... unexpected success

Heya @howjmay, if there's confusion on how to do it or you don't have enough time to do so let me know and I'll fix the tests as needed.

Hi @DimitrisJim I was busy in the past week. I am starting to fix it once again

@DimitrisJim I am feel sorry that I still can't solve this. I have no idea how to get the correct stack size

@howjmay try going into Lib/test/test_compile.py and removing the lines that say

# TODO: RUSTPYTHON
@unittest.expectedFailure

your previous commit (c80802d) was perfectly fine here! Like @fanninpm mentions, just go through the tests in test_compile and remove the decorators marking the functions as failing.

If the stack depth is calculated incorrectly in some cases, that's another subject. This PR just takes care of exposing it for now so don't worry about it.

@fanninpm @DimitrisJim Ah thanks! I was totally misunderstood. Let me fix it!

yeah, sorry if I didn't make myself clear enough. The idea here is to remove any decorators (and their preceding comment) for the tests that now pass. If you revert the changes you've made to test_compile.py and then run:

cargo run --release --features ssl,jit -- -m test -j 1 -u all --slowest --fail-env-changed -v test_compile

this will execute the test runner for this specific file. After you do that you'll notice that for some of the functions (the ones in #4554 (comment)) the test actually passed (there will be a message saying 'Unexpected success'). For these you'll just need to remove the # TODO: RUSTPYTHON comment and @unittest.expectedFailure so the test runner can now accept them as succeeding.

Hope I made it clear! Feel free to ask if something is confusing.

Thank you @DimitrisJim. I just pushed a commit to fix

Thanks!