When not using the builtin zlib, link it before linking libcrypto, as libcrypto depends on zlib.#581
Merged
WayneD merged 1 commit intoRsyncProject:masterfrom Nov 20, 2024
Conversation
Member
|
@WayneD seems sensible to me, ok to merge? |
tridge
force-pushed
the
link-zlib-before-crypto
branch
2 times, most recently
from
2a2116e to
10bbdfd
Compare
Romain-Geissler-1A
force-pushed
the
link-zlib-before-crypto
branch
from
10bbdfd to
cb2da03
Compare
Contributor
Author
|
Hi, I see you have recently cut a release. Would it be possible to consider this small pull request so that we have it included in the next release ? Thanks ! |
… libcrypto depends on zlib. This prevents "undefined symbol" errors which might arise from libcrypto.a if linking openssl statically.
tridge
force-pushed
the
link-zlib-before-crypto
branch
from
cb2da03 to
c78509f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents "undefined symbol" errors which might arise from libcrypto.a if linking openssl statically.
This happens to me as:
--with-included-zlib=no.With this configuration, rsync fails to link with errors like:
To fix fix, make sure we link zlib before we link libcrypto (as zlib may be dependency of libcrypto). This only moves code, without changing anything else.