[FIX] channels.history, groups.history and im.history REST endpoints not respecting hide system message config#22364
Merged
sampaiodiego merged 1 commit intodevelopfrom Jun 16, 2021
Conversation
KevLehman
reviewed
Jun 15, 2021
|
|
||
| export type SettingValueMultiSelect = Array<{key: string; i18nLabel: string}> | ||
| export type SettingValueRoomPick = Array<{_id: string; name: string}> | string | ||
| export type SettingValueMultiSelect = string[]; |
Member
Author
There was a problem hiding this comment.
🤫
jk 😂 the type was actually wrong.. the value for a multi-select setting is an array of strings.. so I had to fix the type to be able to use it correctly.
Member
Author
There was a problem hiding this comment.
here is the setting record:
{
"_id" : "Hide_System_Messages",
"createdAt" : ISODate("2021-01-11T12:21:35.320Z"),
"group" : "Message",
"i18nDescription" : "Hide_System_Messages_Description",
"i18nLabel" : "Hide_System_Messages",
"ts" : ISODate("2021-06-14T12:21:41.761Z"),
"type" : "multiSelect",
"value" : [
"uj",
"ul",
"ru"
],
"values" : [
{
"key" : "uj",
"i18nLabel" : "Message_HideType_uj"
},
{
"key" : "ul",
"i18nLabel" : "Message_HideType_ul"
},
{
"key" : "ru",
"i18nLabel" : "Message_HideType_ru"
},
{
"key" : "au",
"i18nLabel" : "Message_HideType_au"
},
{
"key" : "mute_unmute",
"i18nLabel" : "Message_HideType_mute_unmute"
},
{
"key" : "r",
"i18nLabel" : "Message_HideType_r"
},
{
"key" : "ut",
"i18nLabel" : "Message_HideType_ut"
},
{
"key" : "wm",
"i18nLabel" : "Message_HideType_wm"
},
{
"key" : "rm",
"i18nLabel" : "Message_HideType_rm"
},
{
"key" : "subscription-role-added",
"i18nLabel" : "Message_HideType_subscription_role_added"
},
{
"key" : "subscription-role-removed",
"i18nLabel" : "Message_HideType_subscription_role_removed"
},
{
"key" : "room_archived",
"i18nLabel" : "Message_HideType_room_archived"
},
{
"key" : "room_unarchived",
"i18nLabel" : "Message_HideType_room_unarchived"
},
{
"key" : "room_changed_privacy",
"i18nLabel" : "Message_HideType_room_changed_privacy"
},
{
"key" : "room_changed_avatar",
"i18nLabel" : "Message_HideType_room_changed_avatar"
},
{
"key" : "room_changed_topic",
"i18nLabel" : "Message_HideType_room_changed_topic"
},
{
"key" : "room_e2e_enabled",
"i18nLabel" : "Message_HideType_room_enabled_encryption"
},
{
"key" : "room_e2e_disabled",
"i18nLabel" : "Message_HideType_room_disabled_encryption"
}
]
}
Member
There was a problem hiding this comment.
Ah I see it 😂 nice nice, let's approve this then 👀
KevLehman
approved these changes
Jun 15, 2021
10 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Closes #20442
Steps to test or reproduce
Further comments