[IMPROVE] Send only relevant data via WebSocket#22258
Merged
sampaiodiego merged 3 commits intodevelopfrom Jun 7, 2021
Merged
Conversation
ggazzo
previously approved these changes
Jun 6, 2021
|
Hi, this change is only for installations which using |
Member
Author
|
hi @emikolajczak this applies to both.. but affects most omnichannel operations as it was what we found changing more data that could not necessarily go to clients. |
|
Understand, i had hope that is fix for Rocket stability issues. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Previously when any data changed on subscriptions or rooms we were getting fresh data from database, to also remove undesired fields, but sometimes the data that changed was not relevant so we were sending the whole object everytime without the fields that actually changed. This change aims to reduce this overhead and also send less data to clients.
Issue(s)
Steps to test or reproduce
Further comments