Skip to content

[FIX] Can't delete file from Room's file list#22191

Merged
dougfabris merged 4 commits intodevelopfrom
fix/delete_file
Jun 11, 2021
Merged

[FIX] Can't delete file from Room's file list#22191
dougfabris merged 4 commits intodevelopfrom
fix/delete_file

Conversation

@gabriellsh
Copy link
Copy Markdown
Member

@gabriellsh gabriellsh commented May 28, 2021 •
edited by dougfabris
Loading

Proposed changes (including videos or screenshots)

before

image

after

image

Issue(s)

Steps to test or reproduce

  • Upload a new file
  • Check if it's possible to delete it

Further comments

@gabriellsh gabriellsh requested a review from a team May 28, 2021 20:26
@dougfabris dougfabris added the stat: ready to merge PR tested and approved waiting for merge label May 31, 2021
@dougfabris dougfabris merged commit f257ff1 into develop Jun 11, 2021
@dougfabris dougfabris deleted the fix/delete_file branch June 11, 2021 12:52
@sampaiodiego sampaiodiego mentioned this pull request Jun 28, 2021
Merged
@mxroute
Copy link
Copy Markdown

mxroute commented Jul 3, 2021 •
edited
Loading

I'm experiencing the same behavior in Direct Messages, on version 3.16.1. I can confirm by logging into a new client and then downloading the file from a DM from the Files section that it hasn't been removed from the server. I would add some supporting screenshot/video but the data is of sensitive nature. The original topic here covers the behavior, it's just in a Direct Message as opposed to a channel.

@dougfabris
Copy link
Copy Markdown
Member

dougfabris commented Jul 3, 2021 •
edited
Loading

@mxroute We're going to check it asap, thanks for reporting!

@dougfabris
Copy link
Copy Markdown
Member

dougfabris commented Jul 6, 2021

I'm experiencing the same behavior in Direct Messages, on version 3.16.1. I can confirm by logging into a new client and then downloading the file from a DM from the Files section that it hasn't been removed from the server. I would add some supporting screenshot/video but the data is of sensitive nature. The original topic here covers the behavior, it's just in a Direct Message as opposed to a channel.

@mxroute fixing the issue here: #22595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougfabris dougfabris dougfabris approved these changes

Assignees

No one assigned

Labels

stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gabriellsh @mxroute @dougfabris