[FIX] Remove useless message options from Omnichannel Rooms#21549
Merged
tiagoevanp merged 4 commits intodevelopfrom May 31, 2021
Merged
[FIX] Remove useless message options from Omnichannel Rooms#21549tiagoevanp merged 4 commits intodevelopfrom
tiagoevanp merged 4 commits intodevelopfrom
Conversation
rafaelblink
changed the title
renatobecker
changed the title
tiagoevanp
suggested changes
May 31, 2021
Contributor
tiagoevanp
left a comment
tiagoevanp
left a comment
There was a problem hiding this comment.
How about change the method name showLivechatMenuActions to isLivechatRoom to turn the code more semantically correct?
rafaelblink
force-pushed
the
omnichannel/useless-message-options
branch
from
57ea2f0 to
3404fb5
Compare
tiagoevanp
approved these changes
May 31, 2021
Contributor
tiagoevanp
left a comment
tiagoevanp
left a comment
There was a problem hiding this comment.
How about change the method name showLivechatMenuActions to isLivechatRoom to turn the code more semantically correct?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Before
After
Issue(s)
Steps to test or reproduce
Further comments