Conversation
|
This pull request introduces 3 alerts and fixes 3 when merging 0796d86 into 84d5470 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 3 alerts and fixes 3 when merging 8496f89 into 84d5470 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 3 alerts and fixes 3 when merging 4e20d10 into 84d5470 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 3 alerts and fixes 3 when merging a6f9f50 into ff6a8ec - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 3 alerts and fixes 3 when merging c97b82f into 11ea742 - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 3 alerts and fixes 3 when merging ed03ff0 into 5cc642d - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request introduces 3 alerts and fixes 3 when merging 205353f into ee19c6b - view on LGTM.com new alerts:
fixed alerts:
|
|
This pull request fixes 3 alerts when merging 2204180 into a0be493 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 2a1ed99 into 7482170 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging d173e94 into 2dac1dd - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 21d6c19 into 2dac1dd - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 217ce83 into 2dac1dd - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging dd3b988 into e3f6c5c - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 225ab94 into 043eb51 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging b2c379f into 043eb51 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 3 alerts when merging 0876b82 into 043eb51 - view on LGTM.com fixed alerts:
|
* Update message bridge * Rename bridge extension from js to ts * Adjustment on bridge typings * Reverting `listeners` bridge back to javascript * Remove comment from api bridge * Reset old js files * Remove new ts files to fix file rename * Properly rename bridge files from js to ts * Replace js code with ts * Add missing await in calls to async functions * Rename abstract class for ServerSettingBridge * Fix rename of bridge class * Fix import * Makes the AppCloudBridge extend the new abstract class * Update Apps-Engine * Fix type errors Co-authored-by: thassiov <[email protected]>
2 participants
Implementation of RocketChat/Rocket.Chat.Apps-engine#399
Proposed changes (including videos or screenshots)
Make the bridge classes extend abstract classes provided by the engine instead of just implementing an interface. The new abstract classes feature proxy methods used for permission verification in each method. This is also offers space to add more behaviors before executing the actual bridge methods.
Issue(s)
Steps to test or reproduce
Further comments
Depends on a new release made with the PR 399. The tests will pass with the new release because it will contain the new bridge classes introduced by the mentioned PR.