Allow printing of parameters in Fortran#1811
Draft
EmilyBourne wants to merge 39 commits intodevelfrom
Draft
Conversation
|
Hello again! Thank you for this new pull request 🤩. Please begin by requesting your checklist using the command |
EmilyBourne
added a commit
that referenced
this pull request
May 14, 2024
Print unknown constants using their values. This fixes #1047 but may be reverted in #1811 to prefer declaring constants with names. However this PR also adds support for `NaN` in C and an associated test. It also removes the duplicate `_print_Constant` function. --------- Co-authored-by: EmilyBourne <[email protected]>
EmilyBourne
added a commit
to pyccel/pyccel-cuda
that referenced
this pull request
May 14, 2024
Print unknown constants using their values. This fixes pyccel#1047 but may be reverted in pyccel#1811 to prefer declaring constants with names. However this PR also adds support for `NaN` in C and an associated test. It also removes the duplicate `_print_Constant` function. --------- Co-authored-by: EmilyBourne <[email protected]>
…efaults to _print_Slice
EmilyBourne
added a commit
that referenced
this pull request
Sep 24, 2024
Print unknown constants using their values. This fixes #1047 but may be reverted in #1811 to prefer declaring constants with names. However this PR also adds support for `NaN` in C and an associated test. It also removes the duplicate `_print_Constant` function. --------- Co-authored-by: EmilyBourne <[email protected]>
EmilyBourne
added a commit
that referenced
this pull request
Sep 24, 2024
Print unknown constants using their values. This fixes #1047 but may be reverted in #1811 to prefer declaring constants with names. However this PR also adds support for `NaN` in C and an associated test. It also removes the duplicate `_print_Constant` function. --------- Co-authored-by: EmilyBourne <[email protected]>
EmilyBourne
added a commit
that referenced
this pull request
Sep 24, 2024
Print unknown constants using their values. This fixes #1047 but may be reverted in #1811 to prefer declaring constants with names. However this PR also adds support for `NaN` in C and an associated test. It also removes the duplicate `_print_Constant` function. --------- Co-authored-by: EmilyBourne <[email protected]>
Merged
EmilyBourne
added a commit
that referenced
this pull request
Jun 19, 2025
When creating the release branch I noticed an import which was accidentally deleted although it is used in the file. This PR puts it back. The object is used here: https://github.com/pyccel/pyccel/blob/devel/pyccel/codegen/printing/ccode.py#L2795 This is the fallback case for Constant which we do not use currently (i.e. it is not currently tested). It will either be removed with #1811 or will start being used and tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the printing of constants as
parameterin Fortran. Use this improvement to avoid unnecessary sign checks when using negative indices.