Skip to content

1.7.0 Allow groundstations to be created ingame/via api#500

Merged
Peppie84 merged 16 commits into
RemoteTechnologiesGroup:1.7.0from
simonmeulenbeek:1.7.0
Oct 12, 2015
Merged

1.7.0 Allow groundstations to be created ingame/via api#500
Peppie84 merged 16 commits into
RemoteTechnologiesGroup:1.7.0from
simonmeulenbeek:1.7.0

Conversation

@simonmeulenbeek

Copy link
Copy Markdown
Contributor

Hello,
I thought it would be cool to have a way of adding groundstations via API. This would allow for example KerbalKonstructs to add functional remotetech groundstations in newly opened bases.

Couple of notes:

  • This is my first time making a pull request and using git(hub) in general. I'm very new to this, but I'm willing to learn. If I made a mistake, please don't hesitate to call me out on it.
  • I'm using monodevelop on linux, and it has problems with default arguments so for it to compile I've had to change all the RTLog.Notify("something"); into RTLog.Notify("something", RTLogLevel.x)11

@simonmeulenbeek simonmeulenbeek changed the title 1.7.0 Allow groundstations to be created ingame 1.7.0 Allow groundstations to be created ingame/via api Oct 8, 2015
- fixed merge conflict
- add comments
- and some tweaks on the new methods
@Peppie84

Copy link
Copy Markdown
Member

Hi @Legacynl
i've created a pr on your side to fix the merge conflict. Please look that your branche is always up to date with the branche you want to add a new feature.

Edit: I've changed some of your new methods. Can you please test my changes?

Peppie84 and others added 5 commits October 11, 2015 11:49
The label `Local control` and the yellow flight computer button will now
change the color when the vessel has no connection.
Better local control and connected status
@Peppie84

Copy link
Copy Markdown
Member

@Legacynl i've create a new merge fix on your fork. Can you please merge this as well? My pull requests from today: #502 cause this conflict with your branche.

@simonmeulenbeek

Copy link
Copy Markdown
Contributor Author

@Peppie23 I merged your pr's. There was a bug where I was able to remove KSC, because Guid.ToString() defaults to show hyphens(-), but I believe it works right now. Do I need to make another pull request?

@Peppie84

Copy link
Copy Markdown
Member

@Legacynl no your last pr is registered. Btw thx for this feature.

Peppie84 added a commit that referenced this pull request Oct 12, 2015
1.7.0 Allow groundstations to be created ingame/via api
@Peppie84 Peppie84 merged commit baac6f6 into RemoteTechnologiesGroup:1.7.0 Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants