Fix unload error take 3#420
Merged
Peppie84 merged 2 commits intoMay 16, 2015
Merged
Conversation
I hope this is the last unload error. The problem is that the onRails will be triggered right after 400m. Our condition `v.parts.count==0` is not true and we'll never reregister the satellite. I'll now trigger our onRails method right after the last part is unloaded. I've also added a new method `RTUtil.GetVesselById(Guid vesselid)`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope this is the last unload error. The problem is that the onRails will be triggered right after 400m. Our condition
v.parts.count==0is not true and we'll never reregister the satellite. I'll now trigger ouronRails method right after the last part is unloaded.
I've also added a new method
RTUtil.GetVesselById(Guid vesselid)Fixes #128
Fixes #345