Time strings now converted correctly #206
Merged
Starstrider42 merged 2 commits intoOct 8, 2014
Merged
Conversation
- Removed all System.TimeSpan's - Created a new Folder 'Utils' - Created a new class 'TimeStringConverter' with two sub-classes Earth-/KerbinTimeStringConverter Fixes RemoteTechnologiesGroup#192
- TimeStringConverter moved to SimpleTypes - Utils folder removed - KerbinDays are now 426 and not 365 and removed the const DaysPerYear
Contributor
|
Aha, I figured out the source of my confusion. I thought that Regex.Matches() had to match the whole string all at once; instead, when parsing e.g. "4d 3h" it returns a match for just "4d", followed by a match for just "3h". (This leads to some interesting and unexpected behavior. Type e.g. "10y 3d 10y" into the manual delay box, and the delay will be 20 years and 3 days.) |
Starstrider42
added a commit
that referenced
this pull request
Oct 8, 2014
Time strings now converted correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #192