Skip to content

Cherry-pick: RDB load - return error on failure#1541

Open
AvivDavid23 wants to merge 1 commit into2.4from
cherry-pick-8cf64ec-to-2.4
Open

Cherry-pick: RDB load - return error on failure#1541
AvivDavid23 wants to merge 1 commit into2.4from
cherry-pick-8cf64ec-to-2.4

Conversation

@AvivDavid23
Copy link
Copy Markdown
Contributor

@AvivDavid23 AvivDavid23 commented Apr 7, 2026

Cherry-pick of 8cf64ec2bb83c4365941e768a7ffde5a3134b7e4 onto 2.4.

Propagates RDB load failures instead of swallowing them.

Made with Cursor


Note

Medium Risk
Changes legacy RDB deserialization to return structured Errors instead of panicking/unwrap()ing, which affects database loading behavior on invalid/corrupt data or unexpected encoding versions.

Overview
Improves legacy RedisJSON RDB loading by propagating failures as Result errors rather than crashing the module.

backward::json_rdb_load now uses TryFrom<u64> for NodeType so unknown node type tags return an Error instead of panic!, and nested dict entries also use fallible conversion.

value_rdb_load_json now propagates JSON serialization/UTF-8 failures with ? and returns an explicit error for unsupported encver values instead of panic!.

Reviewed by Cursor Bugbot for commit d09212a. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant