Cherry-pick: RDB load - return error on failure#1541
Open
AvivDavid23 wants to merge 1 commit into2.4from
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of
8cf64ec2bb83c4365941e768a7ffde5a3134b7e4onto2.4.Propagates RDB load failures instead of swallowing them.
Made with Cursor
Note
Medium Risk
Changes legacy RDB deserialization to return structured
Errors instead of panicking/unwrap()ing, which affects database loading behavior on invalid/corrupt data or unexpected encoding versions.Overview
Improves legacy RedisJSON RDB loading by propagating failures as
Resulterrors rather than crashing the module.backward::json_rdb_loadnow usesTryFrom<u64>forNodeTypeso unknown node type tags return anErrorinstead ofpanic!, and nested dict entries also use fallible conversion.value_rdb_load_jsonnow propagates JSON serialization/UTF-8 failures with?and returns an explicit error for unsupportedencvervalues instead ofpanic!.Reviewed by Cursor Bugbot for commit d09212a. Bugbot is set up for automated code reviews on this repo. Configure here.