Cherry-pick: RDB load - return error on failure#1537
Open
AvivDavid23 wants to merge 1 commit into8.2from
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.2 #1537 +/- ##
==========================================
- Coverage 79.20% 78.74% -0.46%
==========================================
Files 15 14 -1
Lines 3707 3547 -160
==========================================
- Hits 2936 2793 -143
+ Misses 771 754 -17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of
8cf64ec2bb83c4365941e768a7ffde5a3134b7e4onto8.2.Propagates RDB load failures instead of swallowing them (backward compatibility / error handling).
Made with Cursor
Note
Medium Risk
Changes RDB loading to return
RedisErrorinstead of panicking/unwrapping, which affects module startup/data loading paths; mistakes could reject previously-loadable dumps or change failure behavior.Overview
Improves failure handling for RedisJSON RDB loads. Legacy RDB parsing now uses
TryFromand returnsRedisErrorfor unknown node types instead of panicking, and nested dict parsing propagates these failures.When loading encoding version
0, JSON serialization and UTF-8 conversion now propagate errors (replacingunwrap()), and unsupportedencvervalues return a descriptiveRedisErrorinstead of panicking.Reviewed by Cursor Bugbot for commit f4d0020. Bugbot is set up for automated code reviews on this repo. Configure here.