MOD-14672 RDB load - return error on failure#1535
Open
AvivDavid23 wants to merge 1 commit into8.6from
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 8.6 #1535 +/- ##
==========================================
- Coverage 77.57% 77.51% -0.07%
==========================================
Files 15 15
Lines 3835 3838 +3
==========================================
Hits 2975 2975
- Misses 860 863 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches RDB deserialization paths; while the change is small, it affects startup/data loading behavior and could alter how corrupted/unsupported RDBs are handled.
Overview
Improves failure handling during legacy RDB load. The legacy node-type decoder in
backward.rsis switched fromFrom<u64>(panic on unknown) toTryFrom<u64>so unknown node types return aRedisErrorand propagate via?.Avoids panics in
value_rdb_load_json. The RDB-load path now propagatesserde_json::SerializeandString::from_utf8failures, and unsupportedencvervalues return a descriptiveRedisErrorinstead of panicking.Reviewed by Cursor Bugbot for commit 8cf64ec. Bugbot is set up for automated code reviews on this repo. Configure here.