minor bug fix in f.h to no require setting of ncp argument

eddelbuettel · eddelbuettel · commit 6c49787edec9 · 2011-11-13T19:05:49.000Z
new unit test for pf() to complement one for pnf()
diff --git a/ChangeLog b/ChangeLog
@@ -1,6 +1,8 @@
 2011-11-13  Dirk Eddelbuettel  <edd@debian.org>
 
-	* inst/unitTests/runit.stats.R: Add unit test for pnf() 
+	* inst/include/Rcpp/stats/f.h: Correct call to not require ncp parameter
+
+	* inst/unitTests/runit.stats.R: Add unit test for pf() and pnf() 
 
 2011-11-07  Romain Francois  <romain@r-enthusiasts.com>
 
diff --git a/inst/NEWS b/inst/NEWS
@@ -8,7 +8,7 @@
         of them. This work has been sponsored by the Google Open Source
         Programs Office. 
 
-    o   New unit test for pnf() (ie prob. function of a non-central F dist.)
+    o   New unit test for pf() and pnf() 
 
 0.9.7   2011-09-29
 
diff --git a/inst/include/Rcpp/stats/f.h b/inst/include/Rcpp/stats/f.h
@@ -22,7 +22,7 @@
 #ifndef Rcpp__stats__f_h
 #define Rcpp__stats__f_h
 
-RCPP_DPQ_3(f,::Rf_df,::Rf_pf,::Rf_qf)
+RCPP_DPQ_2(f,::Rf_df,::Rf_pf,::Rf_qf)
 
 #endif
 
diff --git a/inst/unitTests/runit.stats.R b/inst/unitTests/runit.stats.R
@@ -148,10 +148,21 @@ definitions <- function(){
 				  signature( x = "numeric" ),
 				  '
 				  NumericVector xx(x) ;
-				  return List::create(_["lowerNoLog"] = pnf( xx, 6.0, 8.0, 0.0, true ),
-									  _["lowerLog"]	  = pnf( xx, 6.0, 8.0, 0.0, true, true ),
-									  _["upperNoLog"] = pnf( xx, 6.0, 8.0, 0.0, false ),
-									  _["upperLog"]	  = pnf( xx, 6.0, 8.0, 0.0, false, true ));
+				  return List::create(_["lowerNoLog"] = pnf( xx, 6.0, 8.0, 2.5, true ),
+									  _["lowerLog"]	  = pnf( xx, 6.0, 8.0, 2.5, true, true ),
+									  _["upperNoLog"] = pnf( xx, 6.0, 8.0, 2.5, false ),
+									  _["upperLog"]	  = pnf( xx, 6.0, 8.0, 2.5, false, true ));
+				  ')
+
+				  ,
+				  "runit_pf" = list(
+				  signature( x = "numeric" ),
+				  '
+				  NumericVector xx(x) ;
+				  return List::create(_["lowerNoLog"] = pf( xx, 6.0, 8.0 ),
+									  _["lowerLog"]	  = pf( xx, 6.0, 8.0, true, true ),
+									  _["upperNoLog"] = pf( xx, 6.0, 8.0, false ),
+									  _["upperLog"]	  = pf( xx, 6.0, 8.0, false, true ));
 				  ')
 
 				  ,
@@ -383,8 +394,8 @@ test.stats.punif <- function( ) {
     # TODO: also borrow from R's d-p-q-r-tests.R
 }
 
-test.stats.pnf <- function( ) {
-    fx <- .rcpp.stats$runit_pnf
+test.stats.pf <- function( ) {
+    fx <- .rcpp.stats$runit_pf
     v <- (1:9)/10
     checkEquals(fx(v),
                 list(lowerNoLog = pf(v, 6, 8, lower=TRUE, log=FALSE),
@@ -395,6 +406,18 @@ test.stats.pnf <- function( ) {
                 msg = "stats.pf" )
 }
 
+test.stats.pnf <- function( ) {
+    fx <- .rcpp.stats$runit_pnf
+    v <- (1:9)/10
+    checkEquals(fx(v),
+                list(lowerNoLog = pf(v, 6, 8, ncp=2.5, lower=TRUE, log=FALSE),
+                     lowerLog   = pf(v, 6, 8, ncp=2.5, log=TRUE ),
+                     upperNoLog = pf(v, 6, 8, ncp=2.5, lower=FALSE),
+                     upperLog   = pf(v, 6, 8, ncp=2.5, lower=FALSE, log=TRUE)
+                     ),
+                msg = "stats.pnf" )
+}
+
 test.stats.pgamma <- function( ) {
     fx <- .rcpp.stats$runit_pgamma
     v <- (1:9)/10

-Original file line number
+Diff line change
@@ @@ -1,6 +1,8 @@ @@
 -11-13  Dirk Eddelbuettel  <[email protected]>
 -	* inst/unitTests/runit.stats.R: Add unit test for pnf()
 +	* inst/include/Rcpp/stats/f.h: Correct call to not require ncp parameter
++
 +	* inst/unitTests/runit.stats.R: Add unit test for pf() and pnf()
 -11-07  Romain Francois  <[email protected]>