fix: navigation in dropdown menu with a separator#9474
Merged
gonfunko merged 1 commit intoRaspberryPiFoundation:mainfrom Dec 4, 2025
Merged
fix: navigation in dropdown menu with a separator#9474gonfunko merged 1 commit intoRaspberryPiFoundation:mainfrom
gonfunko merged 1 commit intoRaspberryPiFoundation:mainfrom
Conversation
Collaborator
|
Just to check, is this ready for review @microbit-robert or ongoing? I notice some CI failures so I wanted to check. Also due to the repository migration we don't have auto-reviewer assignment working anymore so that needs to be done manually (for now). |
microbit-robert
force-pushed
the
fix-menu-nav
branch
from
c30c07f to
02e613a
Compare
Collaborator
Author
|
@BenHenning I rebased on latest |
Collaborator
Thanks. I agree that the CI issues should be unrelated. |
gonfunko
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #9473
Proposed Changes
Consistently use
getMenuItems()for highlight methods in dropdown menus.Reason for Changes
The
getMenuItems()method filters out menu separators that otherwise break keyboard navigation in the menus due to an index error.Test Coverage
Documentation
Additional Information