Merged
Conversation
euronion
requested changes
May 13, 2025
Collaborator
euronion
left a comment
euronion
left a comment
There was a problem hiding this comment.
More data, nice! :)
Some comments. Can you also merge the current master so we can check whether there are no unintended overlaps? Thanks!
inputs/manual_input.csv
Outdated
| iron-air battery discharge,efficiency,2035,0.62,per unit,2023,"Form Energy, docu/FormEnergy_Europe_modeling_recommendations_2023.03.pdf, p4", | ||
| iron-air battery discharge,efficiency,2040,0.63,per unit,2023,"Form Energy, docu/FormEnergy_Europe_modeling_recommendations_2023.03.pdf, p4", | ||
| iron-air battery,lifetime,2030,17.5,years,2023,"Form Energy, docu/FormEnergy_Europe_modeling_recommendations_2023.03.pdf, p4", | ||
| ethanol capture retrofit,FOM,2030,7,%/year,2019,"National Petroleum Council, Meeting the Dual Challenge - A Roadmap to At-Scale Deployment of Carbon Capture, Use, and Storage: https://dualchallenge.npc.org/files/CCUS-Chap_2-030521.pdf, accessed 2024-16-04", |
Collaborator
There was a problem hiding this comment.
- Can you check the "accessed" date? Should that be 2025? The date format is also bad, please use YYYY-MM-DD .
- Can you add the page or table number from where you got the information?
- Can we make the naming more clear, i.e. this is
ethanol carbon capture retrofit, right, i.e. for retrofitting carbon capture to an ethanol plant? (applies to all other new entries as well)
Contributor
Author
There was a problem hiding this comment.
Thanks @euronion, thanks for noticing the issue about date! My bad!
Concerning more details on the origin of data and naming I also made the requested changes!
euronion
approved these changes
May 14, 2025
Collaborator
euronion
left a comment
euronion
left a comment
There was a problem hiding this comment.
Thanks for the changes. Spot checked, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR adds data to model:
The source is https://dualchallenge.npc.org/files/CCUS-Chap_2-030521.pdf (provided by ICCT). The plan is to integrate those technologies in PyPSA-Earth taking advantage of the technologies added in Add more industry data #211 .
Checklist
doc.environment.yaml(if applicable).doc/release_notes.rstof the upcoming release is included.